Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #290 - set is_parent_rta for ParseDescriptorBlockVariableSizes #291

Closed

Conversation

danginsburg
Copy link
Contributor

@danginsburg danginsburg commented Dec 4, 2024

so that they don't get padded to 16-byte size.

Changes the output for the shader in the bug report as follows:

generator       : Khronos SPIR-V Tools Assembler
source lang     : Unknown
source lang ver : 1
source file     :
entry point     : main (stage=CS)
local size      : (1, 1, 1)


  Push constant blocks: 1

    0:
      spirv id : 2
      name     : pushConstant (Data_std430)
          // size = 4, padded size = 4
          struct Data_std430 {
              int x; // abs offset = 0, rel offset = 0, size = 4, padded size = 4
          } pushConstant;



  Descriptor bindings: 1

    Binding 0.0
      spirv id : 3
      set      : 0
      binding  : 0
      type     : VK_DESCRIPTOR_TYPE_STORAGE_IMAGE (UAV)
      count    : 1
      accessed : true
      name     : g_Output

…lockVariableSizes so that they don't get padded to 16-byte size.
@spencer-lunarg spencer-lunarg changed the title Fixes issue #290 - set is_parent_rta for ParseDescriptorBlockVariable… Fixes issue #290 - set is_parent_rta for ParseDescriptorBlockVariableSizes Dec 5, 2024
@spencer-lunarg
Copy link
Contributor

This will need to update the golden test YAML for other things

cmake -S . -B build -DCMAKE_BUILD_TYPE=Release
cmake --build build
python tests\build_golden_yaml.py

The case you had this works, but I am still looking into if the BufferDeviceAddress handles make sense or not for the new size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants