Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPError wraps full Response for typed output #366

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

HTTPError wraps full Response for typed output #366

wants to merge 1 commit into from

Conversation

HaraldNordgren
Copy link
Contributor

@HaraldNordgren HaraldNordgren commented Dec 2, 2024 •
edited
Loading

Follow-up to #363. Go one step further lets HTTPError wrap Response to get fully typed error data.

I have:

  • Written a clear PR title and description (above)
  • Signed the Khan Academy CLA
  • Added tests covering my changes, if applicable
  • Included a link to the issue fixed, if applicable
  • Included documentation, for new features
  • Added an entry to the changelog

@HaraldNordgren HaraldNordgren force-pushed the error_body branch 3 times, most recently from 1b362fd to 16e4c7f Compare December 2, 2024 20:00
@HaraldNordgren HaraldNordgren mentioned this pull request Dec 2, 2024
Merged
6 tasks
@HaraldNordgren HaraldNordgren changed the title Return full errors HTTPError wraps full Response for typed output Dec 2, 2024
@HaraldNordgren HaraldNordgren marked this pull request as ready for review December 2, 2024 21:51
@HaraldNordgren
Copy link
Contributor Author

Ping @benjaminjkraft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminjkraft benjaminjkraft Awaiting requested review from benjaminjkraft benjaminjkraft is a code owner

@csilvers csilvers Awaiting requested review from csilvers csilvers is a code owner

@dnerdy dnerdy Awaiting requested review from dnerdy dnerdy is a code owner

@StevenACoffman StevenACoffman Awaiting requested review from StevenACoffman StevenACoffman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HaraldNordgren