Skip to content

Commit

Permalink
Video Block: Disable autoplay when video is not muted (WordPress#69232)
Browse files Browse the repository at this point in the history
Co-authored-by: Rishit30G <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: hanneslsm <[email protected]>
Co-authored-by: yogeshbhutkar <[email protected]>
Co-authored-by: Infinite-Null <[email protected]>
Co-authored-by: carolinan <[email protected]>
  • Loading branch information
7 people authored and Kallyan01 committed Feb 24, 2025
1 parent 51c0f7c commit 429b34a
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions packages/block-library/src/video/edit-common-settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ const VideoSettings = ( { setAttributes, attributes } ) => {
const autoPlayHelpText = __(
'Autoplay may cause usability issues for some users.'
);

const getAutoplayHelp = Platform.select( {
web: useCallback( ( checked ) => {
return checked ? autoPlayHelpText : null;
Expand All @@ -32,7 +33,11 @@ const VideoSettings = ( { setAttributes, attributes } ) => {
const toggleFactory = useMemo( () => {
const toggleAttribute = ( attribute ) => {
return ( newValue ) => {
setAttributes( { [ attribute ]: newValue } );
setAttributes( {
[ attribute ]: newValue,
// Set muted when autoplay changes
...( attribute === 'autoplay' && { muted: newValue } ),
} );
};
};

Expand All @@ -56,7 +61,7 @@ const VideoSettings = ( { setAttributes, attributes } ) => {
isShownByDefault
hasValue={ () => !! autoplay }
onDeselect={ () => {
setAttributes( { autoplay: false } );
setAttributes( { autoplay: false, muted: false } );
} }
>
<ToggleControl
Expand Down Expand Up @@ -95,6 +100,10 @@ const VideoSettings = ( { setAttributes, attributes } ) => {
label={ __( 'Muted' ) }
onChange={ toggleFactory.muted }
checked={ !! muted }
disabled={ autoplay }
help={
autoplay ? __( 'Muted because of Autoplay.' ) : null
}
/>
</ToolsPanelItem>
<ToolsPanelItem
Expand Down

0 comments on commit 429b34a

Please sign in to comment.