remove [[maybe_unused]] to appease windows

JungerBoyo · Jan 5, 2024 · 158b0f4 · 158b0f4
1 parent aaddc7d
commit 158b0f4
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/src/engine/chunk_data_streamer.cpp b/src/engine/chunk_data_streamer.cpp
@@ -13,7 +13,7 @@ ChunkDataStreamer::ChunkDataStreamer(u32 threads_count, std::unique_ptr<ChunkGen
         for (std::uint32_t i{ 0U }; i < final_threads_count; ++i) {
             _threads.push_back(std::jthread(&ChunkDataStreamer::thread, this));
         }
-    } catch([[maybe_unused]] const std::exception&) {
+    } catch(const std::exception&) {
         _done = true;
     }
 }

diff --git a/src/engine/world_grid.cpp b/src/engine/world_grid.cpp
@@ -73,7 +73,7 @@ void WorldGrid::init() {
         _visible_chunks.reserve(max_chunks);
         _free_visible_chunk_ids.resize(max_chunks);
         _visible_chunk_id_to_index.resize(max_chunks, INVALID_VISIBLE_CHUNK_INDEX);
-    } catch ([[maybe_unused]] const std::exception&) {
+    } catch (const std::exception&) {
         _engine_context.error |= Error::CPU_ALLOCATION_FAILED;
         return;
     }

diff --git a/src/sandbox_utils/simple_terrain_generator.cpp b/src/sandbox_utils/simple_terrain_generator.cpp
@@ -34,6 +34,6 @@ void SimpleTerrainGenerator::threadInit() {
     _data.resize(_chunk_size[0] *  _chunk_size[1] *  _chunk_size[2], 0U);
     makeCorridor(_data, _chunk_size);
 }
-std::optional<std::span<const u16>> SimpleTerrainGenerator::gen([[maybe_unused]]Vec3i32 chunk_position) {
+std::optional<std::span<const u16>> SimpleTerrainGenerator::gen(Vec3i32 chunk_position) {
     return std::span<const u16>(_data);
 }
diff --git a/src/sandbox_utils/simple_terrain_generator.h b/src/sandbox_utils/simple_terrain_generator.h
@@ -14,7 +14,7 @@ struct SimpleTerrainGenerator : public ChunkGenerator {
     SimpleTerrainGenerator(vmath::Vec3i32 chunk_size);
 
     void threadInit() override;
-    std::optional<std::span<const vmath::u16>> gen([[maybe_unused]] vmath::Vec3i32 chunk_position) override;
+    std::optional<std::span<const vmath::u16>> gen(vmath::Vec3i32 chunk_position) override;
 };
 
 }

diff --git a/src/ve001_benchmark.cpp b/src/ve001_benchmark.cpp
@@ -274,7 +274,7 @@ int main(int argc, const char* const* argv) {
         if (camera_moved || camera_rotated) {
 
             if (cli_app_config.frustum_culling) {
-                static constexpr auto TAN_FOV = std::tan(CAMERA_FOV_BIASED/2.F);
+                static const auto TAN_FOV = std::tan(CAMERA_FOV_BIASED/2.F);
                 const auto aspect_ratio = (static_cast<vmath::f32>(window_width)/static_cast<vmath::f32>(window_height));
 
                 engine.applyFrustumCullingPartition(