Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set artifact to tzdata2025a and project to 1.4.0+2025a #33

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Set artifact to tzdata2025a and project to 1.4.0+2025a #33

merged 1 commit into from
Feb 10, 2025

Conversation

omus
Copy link
Member

@omus omus commented Jan 18, 2025

An automated PR generated by the Update workflow.

@omus
Copy link
Member Author

omus commented Jan 20, 2025

Something went wrong the the automated PR

@omus
Copy link
Member Author

omus commented Feb 10, 2025

Finally going to look into this today

@omus
Copy link
Member Author

omus commented Feb 10, 2025

The artifact we attempt to download does indeed exist: https://github.com/JuliaTime/TZJData.jl/actions/runs/12842970210

@omus
Copy link
Member Author

omus commented Feb 10, 2025

Found something. The failed jobs tried to retrieve the artifact from workflow run 12826647468 instead of 12842970210 which contains the artifact.

@github-actions github-actions bot force-pushed the gh/update-tzdata branch 3 times, most recently from 44dfe44 to 8e6b68e Compare February 10, 2025 20:50
@omus omus mentioned this pull request Feb 10, 2025
Merged
@omus
Copy link
Member Author

omus commented Feb 10, 2025 •
edited
Loading

I should deal with this first:

┌ Warning: Discovered offset -15:56:08 less than the expected min -15:56:00
└ @ TimeZones.TZData ~/.julia/packages/TimeZones/52qdp/src/tzdata/compile.jl:331

– https://github.com/JuliaTime/TZJData.jl/actions/runs/13250532486/job/36987170305#step:6:26

@omus omus mentioned this pull request Feb 10, 2025
Merged
@omus
Copy link
Member Author

omus commented Feb 10, 2025

Offset discrepancy didn't seem to be an actual problem. However, from some manual checks on macOS I'm seeing a different tree SHA with the updated TimeZones.jl and the old TimeZones.jl so I'll wait here to be safe

@omus
Copy link
Member Author

omus commented Feb 10, 2025

Current artifact SHA256: c3b0bda3c12abc8b8f5f757fe31486551fb1b719332e2426287e47db3c5d733e

@omus
Copy link
Member Author

omus commented Feb 10, 2025

New versions of TimeZones.jl produces identical results as I thought it would

@omus omus merged commit ecb74d6 into main Feb 10, 2025
4 checks passed
@omus omus deleted the gh/update-tzdata branch February 10, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@omus