Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #121: Add REPL to weakdepends in temp Manifest #125

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

pjaap
Copy link
Contributor

@pjaap pjaap commented Dec 10, 2024

This should fix #121

Steps to reproduce the previous failure:

$ git clone https://github.com/pjaap/TestPackage.jl # simple package with a single unit test
$ julia
] activate @v1.11
] add TestReports
] activate TestPackage.jl
julia> using TestReports
julia> TestReports.test("TestPackage") # crash

Adding TestReports in the TestPackage environment does not create a crash.

@pjaap pjaap mentioned this pull request Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (54191fb) to head (1d232de).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   96.40%   93.38%   -3.03%     
==========================================
  Files           7        7              
  Lines         557      484      -73     
==========================================
- Hits          537      452      -85     
- Misses         20       32      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@KristofferC KristofferC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may temporarily fix the issue but if some other stdlibs adds a weakdep or something this package will break again.

@KristofferC KristofferC merged commit 0d7240d into JuliaTesting:master Jan 29, 2025
7 checks passed
@galindro
Copy link

Tks @KristofferC !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashing on Julia 1.11-rc1
3 participants