Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Arrow v2.8.0 #120826

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Dec 6, 2024

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. AutoMerge Guidelines are all met! ✅

Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round (~20 minutes).

2. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@kou
Copy link

kou commented Dec 7, 2024

@quinnj @baumgold @ericphanson Could you take a look at this?

@JuliaTagBot JuliaTagBot added the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Dec 7, 2024
@quinnj
Copy link
Contributor

quinnj commented Dec 7, 2024

Ah shoot, that's my mistake. I'll prepare a fix. [noblock]

UUID: 69666777-d1a9-59fb-9406-91d4454c9d45
Repo: https://github.com/apache/arrow-julia.git
Tree: 00f0b3f05bc33cc5b68db6cc22e4a7b16b65e505

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-arrow-69666777-v2.8.0-8f0049e691 branch from c1956c3 to f5c882b Compare December 7, 2024 23:54
JuliaRegistrator referenced this pull request in apache/arrow-julia Dec 7, 2024
@quinnj
Copy link
Contributor

quinnj commented Dec 7, 2024

@kou, you'll need to edit your comment to add [noblock] to unblock the auto-merge of this PR [noblock]

@ericphanson ericphanson added the Override AutoMerge: ignore blocking comments Instructs automerge to ignore blocking comments label Dec 8, 2024
@JuliaTagBot JuliaTagBot removed the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Dec 8, 2024
@JuliaTagBot JuliaTagBot merged commit 35fa125 into master Dec 8, 2024
14 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-arrow-69666777-v2.8.0-8f0049e691 branch December 8, 2024 01:25
@kou
Copy link

kou commented Dec 8, 2024

Thanks!
But can we use a new release ("2.8.1" not 2.8.0" in this case) instead of changing voted version when we found a new problem next time?

@ericphanson
Copy link
Member

That makes sense to me. We should also add Aqua.jl tests to Arrow and ArrowTypes, that would catch this issue in the PR instead of at registration time, so this kind of issue would be less likely to occur again.

@quinnj
Copy link
Contributor

quinnj commented Dec 9, 2024

sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor release Override AutoMerge: ignore blocking comments Instructs automerge to ignore blocking comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants