add method for Distributions.rand(::ResettableRNG, ::Binomial) (#249)

* add method for Distributions.rand(::ResettableRNG, ::Binomial * Fix ResettableRNG dispatch * Test with MersenneTwister (Xoshiro not available in Julia 1.6) * bump version --------- Co-authored-by: Chad Scherrer <[email protected]>
JuliaMath · Feb 26, 2023 · a3b8f6d · a3b8f6d · cscherrer · Feb 26, 2023
1 parent 9960e9b
commit a3b8f6d
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "MeasureTheory"
 uuid = "eadaa1a4-d27c-401d-8699-e962e1bbc33b"
 authors = ["Chad Scherrer <[email protected]> and contributors"]
-version = "0.18.1"
+version = "0.18.2"
 
 [deps]
 Accessors = "7d9f7c33-5ae7-4f3b-8dc6-eff91059b697"

diff --git a/src/parameterized/binomial.jl b/src/parameterized/binomial.jl
@@ -23,8 +23,8 @@ end
     x ∈ (0, 1)
 end
 
-function Base.rand(rng::AbstractRNG, ::Type, d::Binomial{(:n, :p)})
-    rand(rng, Dists.Binomial(d.n, d.p))
+function Base.rand(rng::AbstractRNG, ::Type{T}, d::Binomial{(:n, :p)}) where {T}
+    rand(rng, T, Dists.Binomial(d.n, d.p))
 end
 
 Binomial(n) = Binomial(n, 0.5)

diff --git a/src/resettable-rng.jl b/src/resettable-rng.jl
@@ -57,6 +57,14 @@ for T in vcat(subtypes(Signed), subtypes(Unsigned), subtypes(AbstractFloat))
     end
 end
 
+function Base.rand(r::ResettableRNG, d::AbstractMeasure)
+    rand(r.rng, d)
+end
+
+function Base.rand(r::ResettableRNG, ::Type{T}, d::AbstractMeasure) where {T}
+    rand(r.rng, T, d)
+end
+
 Base.iterate(r::ResettableRNG) = iterate(r, nothing)
 
 function Base.iterate(r::ResettableRNG, ::Nothing)

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -116,6 +116,10 @@ end
         @test ℓ ≈ logdensity_def(Binomial(; n, logitp), y)
         @test ℓ ≈ logdensity_def(Binomial(; n, probitp), y)
 
+        rng = ResettableRNG(Random.MersenneTwister())
+        @test rand(rng, Binomial(n=0, p=1.0)) == 0
+        @test rand(rng, Binomial(n=10, p=1.0)) == 10
+
         @test_broken logdensity_def(Binomial(n, p), CountingMeasure(ℤ[0:n]), x) ≈
                      binomlogpdf(n, p, x)
     end