Resolving issue #61: Expressions evaluated to NaN #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `!=` to use `!isequal()` to not get stuck in infinite loops with NaN. Non-trivial test also added that verifies this.
|
Sorry, first time editing packages with julia. Hope this works. Just pinging the issue #61 in here as well. |
|
I don't understand the check error. Let me know if it something that I should fix (and then how). |
|
This looks like it wasn't a real error. I'm going to merge this now. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
!=to use!isequal()to not get stuck in infinite loops with NaN.Non-trivial test also added that verifies this.