Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in recurrence when length is 2 #71

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Fix error in recurrence when length is 2 #71

merged 1 commit into from
Jan 28, 2023

Conversation

heltonmc
Copy link
Member

@heltonmc heltonmc commented Dec 5, 2022

There is an error for the AbstractRange arguments when length(nu) ==2.

julia> besselk(3:4, 1.2)
2-element Vector{Float64}:
 3.910688631242223
 0.0

julia> besseli(3:4, 1.2)
2-element Vector{Float64}:
 0.0
 0.005800666221875795

This is a small fix and I also added some extra docs and tests to release v0.2.8.

I think we should also export all the other functions and release v0.3.0 next. We should ask to contribute the SpecialFunctions.jl port of loggamma and logabsgamma which will separate out native julia code which we will need here. This will also close the concerns in #27 (comment).

@heltonmc heltonmc merged commit 1475e9e into master Jan 28, 2023
@heltonmc heltonmc deleted the fixes branch January 28, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant