Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeInstance: remove relocatability field #56975

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jan 6, 2025

This field lost its meaning awhile back and is better tracked only as part of the compressed CodeInfo instead of trying to accurately copy and update this field.

Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI failure looks real, which looks like we are marking atomic fields incorrectly.

This field lost its meaning awhile back and is better tracked only as
part of the compressed CodeInfo instead of trying to accurately copy and
update this field.
@vtjnash vtjnash force-pushed the jn/relocatibility-field branch from 55cbd3d to d5ff803 Compare January 8, 2025 15:51
@vtjnash vtjnash dismissed aviatesk’s stale review January 8, 2025 15:51

fixed precompile atomic marking

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Jan 8, 2025
@vtjnash vtjnash merged commit 8bf2802 into master Jan 8, 2025
6 of 8 checks passed
@vtjnash vtjnash deleted the jn/relocatibility-field branch January 8, 2025 18:47
@IanButterworth IanButterworth removed the merge me PR is reviewed. Merge when all tests are passing label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants