Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use _ for unused argument [NFC] #4134

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use _ for unused argument [NFC] #4134

wants to merge 2 commits into from

Conversation

LilithHafner
Copy link
Member

No description provided.

@KristofferC
Copy link
Member

I don't think there is any convention about prefixing with an underscore for unused arguments. If anything, just a _ could be used but I don't know if that is better or not.

@LilithHafner
Copy link
Member Author

I read this source code and was briefly confused; replacing with _ would have alleviated my confusion. NBD, feel free to close if maintainers here would rather not.

@LilithHafner LilithHafner changed the title Add underscore before unused argument [NFC] Use _ for unused argument [NFC] Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LilithHafner @KristofferC