Backport nightly precompilation code to 1.10. #4107
Conversation
There was a problem hiding this comment.
Thanks @KristofferC - this is great to have
Can we also add a test for #4095 ?
src/precompilation.jl
Outdated
| is_trigger = in(pkg, direct_deps[ext]) | ||
| is_extension = in(pkg, keys(ext_to_parent)) | ||
| has_triggers = issubset(direct_deps[ext], indirect_deps[pkg]) | ||
| ext_loadable_in_pkg[pkg] = !is_extension && has_triggers && !is_trigger |
There was a problem hiding this comment.
This needs to be the modified behavior that we backported to 1.10, which accounts for its different extension loading behavior:
https://github.com/JuliaLang/Pkg.jl/pull/4093/files#diff-a43f827629f8ae12bbcbb218a293d325afcdda3a7f3c7016e2292840bf29ed1cR1220-R1250
(You should be able to copy-paste it directly, I think)
There was a problem hiding this comment.
Copy pasted with depsmap -> direct_deps and exts -> ext_to_parent renames.
There was a problem hiding this comment.
Oh, you're backporting from master instead of 1.11 - That will make backports a little more annoying since I never backported that rename to 1.11
That might be best for long-term anyway, just wanted to mention it
KristofferC
force-pushed
the
kc/backport_precompile
branch
from
291b111 to
f9d4007
Compare
KristofferC
force-pushed
the
kc/backport_precompile
branch
from
f9d4007 to
8c86a8e
Compare
|
Let's get this onto a 1.10 backport branch so we can test it properly. |
First commit is just copy pasting from nightly. Second commit is actually tweaking it to work with 1.10.