-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backports-release-1.10] Backport julia/#55910 and julia/#56621 #4093
[backports-release-1.10] Backport julia/#55910 and julia/#56621 #4093
Conversation
c2b9348
to
9635d6c
Compare
This is great. Thanks! |
9635d6c
to
65da451
Compare
Done! |
Thanks. CI isn't running because this is merging into a backports branch. Should be fixed by #4094 |
This comment was marked as resolved.
This comment was marked as resolved.
65da451
to
de9d2ec
Compare
If you rebase this now on the base branch it should run CI |
Thanks for the backport! For clarity, this will fix the "false cycles" we were adding on accident before JuliaLang/julia#55910, but it leaves in any true cycles that come from the bad "ext → ext" edge definition we have on 1.10 I think that's the right thing to do - just wanted to make it clear what this does / doesn't fix |
e38b4d8
to
1732d5f
Compare
1.10 backport based off of julia/#56624
…ative (julia/#56621)
1732d5f
to
eb66350
Compare
7a702a6
into
JuliaLang:backports-release-1.10
I think this might fix a significant majority of our cycle problems on 1.10 Extension circularity should now only occur when two extensions have exactly the same* set of triggers, and the cycles should be a lot shorter / more direct (e.g. "ExtAB ↔ extBA") * technically the "same" triggers after transitive reduction, meaning not counting any triggers in the dependencies of another |
Don't squash?
I backported them while looking into JuliaConcurrent/Atomix.jl#44 and figured I might as well submit a PR.