Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backports-release-1.10] Backport julia/#55910 and julia/#56621 #4093

Merged

Conversation

christiangnrd
Copy link
Contributor

Don't squash?

I backported them while looking into JuliaConcurrent/Atomix.jl#44 and figured I might as well submit a PR.

@IanButterworth
Copy link
Member

This is great. Thanks!
Minor thing that helps track backports. Can you make the commit titles include the name of the original PR.

@christiangnrd
Copy link
Contributor Author

Can you make the commit titles include the name of the original PR.

Done!

@IanButterworth
Copy link
Member

Thanks. CI isn't running because this is merging into a backports branch. Should be fixed by #4094

@christiangnrd

This comment was marked as resolved.

@IanButterworth
Copy link
Member

If you rebase this now on the base branch it should run CI

src/API.jl Show resolved Hide resolved
src/API.jl Outdated Show resolved Hide resolved
@topolarity
Copy link
Member

Thanks for the backport!

For clarity, this will fix the "false cycles" we were adding on accident before JuliaLang/julia#55910, but it leaves in any true cycles that come from the bad "ext → ext" edge definition we have on 1.10

I think that's the right thing to do - just wanted to make it clear what this does / doesn't fix

@topolarity topolarity force-pushed the backports branch 3 times, most recently from e38b4d8 to 1732d5f Compare November 23, 2024 22:27
@IanButterworth IanButterworth merged commit 7a702a6 into JuliaLang:backports-release-1.10 Nov 23, 2024
13 checks passed
@topolarity
Copy link
Member

topolarity commented Nov 23, 2024

I think this might fix a significant majority of our cycle problems on 1.10

Extension circularity should now only occur when two extensions have exactly the same* set of triggers, and the cycles should be a lot shorter / more direct (e.g. "ExtAB ↔ extBA")

* technically the "same" triggers after transitive reduction, meaning not counting any triggers in the dependencies of another

@christiangnrd christiangnrd deleted the backports branch November 24, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants