Flexibilize the definition of motion time spans #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New `TimeCurve` struct and - Slight changes in `times` and `sort_motions!` - Allow to and export Booleans in KomaMRIFiles/Phantom.jl
cncastillo
reviewed
Jan 3, 2025
- Change default `TimeRange` in `Motion` constructors from `[-1,0]` to `[0,eps]` - Rename `duration` to `periods` in TimeCurve.jl, Motion.jl and MotionList.jl - Improve docstrings in TimeCurve.jl - Add new figures and remove old ones
- Improve docstrings of `TimeCurve` and its custom constructors. - Add figures to `TimeRange` and `Periodic` docstrings - Remove `unit_time` docstring, since it is not exported
pvillacorta
added
documentation
cncastillo
approved these changes
Jan 6, 2025
pvillacorta
added a commit
that referenced
this pull request
Jan 6, 2025
- Fix error in tests - Fix flow-related undetected errors from #531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR arises from the need to create motion patterns that are currently not replicable in Koma. An example is the figure below, taken from this paper, which shows the temporal evolution of a contraction and torsion motion in the myocardium:
This time curve cannot be replicated either with the
TimeRangestructure or thePeriodicstructure, so a new structure calledTimeCurvehas been defined, which can replicate any arbitrary temporal behaviour.In fact, the
TimeRangeandPeriodicstructures may no longer be necessary if the efficiency of theunit_timefunction with aTimeCurveis better or at least equal to the correspondingunit_timeimplementations withTimeRangeandPeriodic. Efficiency checks are still pending.Additionally, I want to add a field to account for pseudo-periodic motion patterns such as arrhythmias.
https://juliahealth.org/KomaMRI.jl/previews/PR531/