Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recover support for older Julia versions #52

Merged
merged 3 commits into from
Sep 25, 2024
Merged

recover support for older Julia versions #52

merged 3 commits into from
Sep 25, 2024

Conversation

lmiq
Copy link
Collaborator

@lmiq lmiq commented Sep 25, 2024

@carstenbauer

I started updating packages that depend on ChunkSplitters, and noted that we are artificially dropping support for older Julia versions than 1.10. Thus, if we are to suggest people to upgrade, everyone will be forced to drop their support as well.

This is quite inconvenient now, particularly since 1.6 is (still) the LTS, and many people are using 1.9. I feel that suggesting PRs to packages that depend on ChunkSplitters while forcing them to drop support of older Julia versions just for it is not very nice.

The only test that fails in 1.6 is the allocation test with size set, but it does not fail in 1.9 anymore.

@carstenbauer
Copy link
Member

Alright, let's keep/recover 1.6 support. However, I'd drop it once 1.10 is officially declared the new LTS.

@carstenbauer
Copy link
Member

This needs a entry in CHANGELOG.md (for version 3.1).

Regarding the broken test, can you add a @test_broken conditioned on if VERSION < 1.10.0- or similar?

@lmiq
Copy link
Collaborator Author

lmiq commented Sep 25, 2024

However, I'd drop it once 1.10 is officially declared the new LTS.

I would be more conservative. Until most of the dependents migrate their support, I don't see a reason to not support previous version. It is not that we are using any new feature, really.

@lmiq lmiq merged commit f5b3d66 into main Sep 25, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants