Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify iterate method to remove allocation on 1.10. #50

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Simplify iterate method to remove allocation on 1.10. #50

merged 1 commit into from
Sep 24, 2024

Conversation

fredrikekre
Copy link
Contributor

@fredrikekre fredrikekre mentioned this pull request Sep 24, 2024
Merged
6 tasks
@fredrikekre
Copy link
Contributor Author

fredrikekre commented Sep 24, 2024 •
edited
Loading

Well, it does locally but not in CI... Edit: It was just the @test_broken that was no longer broken...

@lmiq
Copy link
Collaborator

lmiq commented Sep 24, 2024

this is great.

Can you educate me on the rationality of the change (if there is one?)

@lmiq lmiq merged commit 6220502 into JuliaFolds2:cb/threepointo Sep 24, 2024
11 of 12 checks passed
@fredrikekre fredrikekre deleted the fe/allocs branch September 24, 2024 14:21
@fredrikekre
Copy link
Contributor Author

Was just a case of looking at the code and seeing that it could be simplified. The compiler prefer simpler code I guess ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @lmiq