Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove @time from tests #121

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

IanButterworth
Copy link
Contributor

@IanButterworth IanButterworth commented Jan 19, 2025

These are noisy on Base CI.

Should both lines just be removed instead? Or are they testing that they don't error?

They were added in #92

  | 2025-01-19 15:18:12 EST | From worker 7:	  0.012981 seconds (19 allocations: 98.805 KiB)
  | 2025-01-19 15:18:12 EST | From worker 7:	  0.010351 seconds (19 allocations: 98.867 KiB)
  | 2025-01-19 15:18:12 EST | SHA                                               (7) \|   118.92 \|   0.13 \|  0.1 \|     361.09 \|  1452.17

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.78%. Comparing base (15f7dbc) to head (08b7c12).
Report is 13 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   99.79%   99.78%   -0.02%     
==========================================
  Files           9        9              
  Lines         490      467      -23     
==========================================
- Hits          489      466      -23     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inkydragon
Copy link
Collaborator

Should both lines just be removed instead?

I think so.
Both tests are supposed to be just to test performance.

test/runtests.jl Outdated Show resolved Hide resolved
@inkydragon inkydragon merged commit 4451e13 into JuliaCrypto:master Jan 20, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants