Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to doc: guidance for choosing polynomial (#213) #219

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

onzerem
Copy link
Contributor

@onzerem onzerem commented Dec 7, 2024

Hi! Thank you for saying yes to my PR. Here's what I added, please let me know what you think. I tried to keep it brief. Thank you!

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.10%. Comparing base (dd8bbb2) to head (9ee2344).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   92.10%   92.10%           
=======================================
  Files          19       19           
  Lines        1863     1863           
=======================================
  Hits         1716     1716           
  Misses        147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty
Copy link
Member

I think it should be phrased more openly, i.e., they are useful for many other things.

Eg., as an author of https://epubs.siam.org/doi/abs/10.1137/120865458?casa_token=b7rSj9AOym4AAAAA:7VcJMj3ueNw2Hx-yKH1JsYFeSNPYeARhrzXR3XJ0v22uZ_jDAav14MQy0BRYp7Ka_VOws90 it would be odd for me to only say ultraspherical polynomials are "useful for spherical harmonics in higher dimensions"

@onzerem
Copy link
Contributor Author

onzerem commented Dec 10, 2024

@dlfivefifty Hi, I made an updated pr with your recommendation to use more open language. Hopefully, I was able to fulfill that without being too wordy, please let me know what you think. Thanks!

I also agree that this could be a good complement #222.

@dlfivefifty dlfivefifty merged commit 10c1bb7 into JuliaApproximation:main Jan 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants