Modify javascript formatting to support IE. Move imports to new file #20
Conversation
|
Thank you so much for taking action! LGTM, any comments @tomalec? |
| }, | ||
| editor: null, | ||
| observer: null, |
There was a problem hiding this comment.
We still use the observer, I'd keep it in the prototype, to make the API known beforehand.
Do we need to move editor to properties? What does it change? I think it may only cost us the performance of Polymer magic on top of that.
There was a problem hiding this comment.
There was a reference to editor being undefined, and the move to polymer properties resolved that. The removal of observer was a misstep. I'll re-add and recheck. Thanks for the feedback!
|
Thanks for the PR! I'm totally 👍 for changing the function declarations, got some questions regarding But speaking of moving imports, I think it's better to move it to separate PR, as I have more doubts there. |
|
I'm totally with you on the imports, this is old pattern that may have since been resolved but we still practice (habits). |
This PR addresses #18 and #19.
A missing function declaration and a shorthand function were modified to support Internet Explorer 11.
Import files were moved into a new html file to leverage browser deduping and prevent multiple script execution.
This can be broken up into separate PRs, unless merging here is acceptable.