Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial generation signature feature toggle. #481

Draft
wants to merge 76 commits into
base: net232
Choose a base branch
from
Draft

Initial generation signature feature toggle. #481

wants to merge 76 commits into from

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Feb 13, 2023

A second attempt at #378.

@nojaf nojaf force-pushed the generate-signature-two branch from af43d0c to 45a07fe Compare February 27, 2023 08:13
@nojaf nojaf changed the base branch from net231 to net232 March 28, 2023 07:50
@nojaf nojaf force-pushed the generate-signature-two branch from 90cdf95 to ca70826 Compare March 29, 2023 11:29
@auduchinok auduchinok force-pushed the generate-signature-two branch from 08c9c23 to 95b98a0 Compare April 19, 2023 12:17
@nojaf nojaf force-pushed the generate-signature-two branch 2 times, most recently from 31f6605 to 8c85309 Compare May 8, 2023 10:12
@nojaf nojaf mentioned this pull request May 8, 2023
Merged
nojaf and others added 16 commits May 8, 2023 15:59
nojaf and others added 28 commits May 24, 2023 11:32
@nojaf
Add namespace test.
f9d5919
@nojaf
Remove old tests file.
501058e
@nojaf
Add _.fsi test.
6aa2c4e
@nojaf
Add initial unit tests.
4c82a24
@dawedawe @nojaf
add test 01 for recursive types
c9e864c
@dawedawe @nojaf
add test for record with static member
bc9797b
@dawedawe @nojaf
add test for union with static member
d9d21c7 
note, we should improve the signature with naming
@nojaf
Add test for instance member.
f7e3638
@dawedawe @nojaf
add test for instance member with optional parameter
d4d33aa
@dawedawe @nojaf
start supporting structs, we might handle it as IObjectModelTypeRepre…
7429d6d 
…sentation in the future, let's see.
@dawedawe @nojaf
start supporting signature generation for ILetBindingsDeclaration
f1cb32e
@dawedawe @nojaf
remove superfluous indentation
c487f06
@dawedawe @nojaf
Use "\n" instead of System.Environment.NewLine
30f8bb4
@nojaf
Add basic exception.
a73a6db
@nojaf
Add members to exceptions.
1d3699d
@nojaf
Add support for delegates.
1f388e7
@nojaf
Implicit unit constructor.
f662765
@nojaf
Implicit constructor with parameters.
62a8938
@nojaf
Reuse lineEnding
0fac3aa
@nojaf
Filter out IExceptionFieldDeclaration for IExceptionDeclaration.
86f4a93
@nojaf
Remove invalid comment.
335bf48
@nojaf
Remove redundant unit pat check in createPrimaryConstructorSignature.
a7833ab
@nojaf
Don't show workflow item is setting is not enabled.
40d85a8
@nojaf
Use TypeMembers for IExceptionDeclaration.
877ab51
@nojaf
Small fixes after rebase.
b3d2de7
@dawedawe @nojaf
Support attributes on module members
da1180f
@dawedawe @nojaf
Add attribute with parameter for test
9713991
@dawedawe @nojaf
Use GetText() to get original attributes from impl file.
de6092e
@nojaf nojaf force-pushed the generate-signature-two branch from b5d33d2 to de6092e Compare May 25, 2023 15:21
@dawedawe
Merge remote-tracking branch 'nojaf/generate-signature-two' into pr/481
f93cdc0 
# Conflicts:
#	ReSharper.FSharp/src/FSharp.Psi.Services/src/Generate/GenerateSignatureProvider.fs
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Delegate 01.fs
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Delegate 01.fs.gold
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Exception 01.fs
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Exception 01.fs.gold
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Instance Member 01.fs
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Instance Member 01.fs.gold
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Module structure 02.fs
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Module structure 02.fs.gold
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Nested module 01.fs
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Nested module 01.fs.gold
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Record 01.fs
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Record 01.fs.gold
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Struct 01.fs
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Struct 01.fs.gold
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Union 01.fs
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Union 01.fs.gold
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Union 02.fs
#	ReSharper.FSharp/test/data/features/generate/signatureFiles/Union 02.fs.gold
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auduchinok auduchinok auduchinok left review comments

@dawedawe dawedawe dawedawe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nojaf @dawedawe @auduchinok