Remove log failure to Console from ExtensionLoader #1259
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ArturDorochowicz Hey man, I'm sorry, but this is the very epitome of the "solves my tactical problem, doesn't address a strategic concern" pull request. I didn't just put the console output on failures there for fun. What you did is essentially swallowing a potential problem. Like I told you before, you can simply opt out of the automatic extension finding altogether. Or come up with some kind of "suppress assembly warnings" flag I guess. |
|
If you wanna try this a different way that just latches the logging on assembly failures, I'm good to take that. But this just treats the symptoms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1258