Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LNK metric #205

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add LNK metric #205

wants to merge 3 commits into from

Conversation

DragaDoncila
Copy link
Collaborator

@DragaDoncila DragaDoncila commented Feb 12, 2025

Proposed Change

Add LNK metric giving 0 weight to node errors. Closes #187.

Types of Changes

  • New feature or enhancement
  • Documentation update

Which topics does your change affect? Delete those that do not apply.

  • Metrics

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the developer/contributing docs.
  • I have added tests that prove that my feature works in various situations or tests the bugfix (if appropriate).
  • I have checked that I maintained or improved code coverage.
  • I have checked the benchmarking action to verify that my changes did not adversely affect performance.
  • I have written docstrings and checked that they render correctly in the Read The Docs build (created after the PR is opened).
  • I have updated the general documentation including Metric descriptions and example notebooks if necessary.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (31be450) to head (8759618).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   95.00%   95.20%   +0.20%     
==========================================
  Files          18       18              
  Lines         921      939      +18     
==========================================
+ Hits          875      894      +19     
+ Misses         46       45       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DragaDoncila DragaDoncila marked this pull request as ready for review February 12, 2025 01:50
@DragaDoncila
Copy link
Collaborator Author

@cmalinmayor @msschwartz21 this ended up a pretty small change, but feedback welcome! I added some more tests but let me know if there's anything you think is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LNK implementation for CTC metrics
1 participant