Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition from numpy.distutils to scikit-build #3

Merged
merged 43 commits into from
Sep 24, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

In preparation to switch from using deprecated ICC to its successor ICX, changed build system from deprecated numpy.distutils to scikit-build.

Renamed files: loops_intel -> mkl_umath_loops

Bumped up the version of the package from 0.1.1 to 0.1.2

AndresGuzman-Ballen and others added 27 commits August 9, 2023 11:17
In preparation to switch from using deprecated ICC to its successor ICX,
changed build system from deprecated numpy.distutils to scikit-build.

Renamed files: loops_intel -> mkl_umath_loops

Bumped up the version of the package from 0.1.1 to 0.1.2

Co-authored-by: Oleksandr Pavlyk <[email protected]>
Co-authored-by: Andres Guzman-Ballen <[email protected]>
Used Python_add_library, instead of removed add_library followed
by python_extension_module function from scikit-build.

Removed superfluous comments
Some loops are not vectorized due to compiler's cost model analysis.
Added CMake option OPTIMIZATION_REPORT (OFF by default). It would
instruct compiler to generate optimization report for mkl_umath
library.
Convert the generated integer to numpy.int64 using type
@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review September 17, 2024 14:02
Adjust variables after move to use NumPy as Python component
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the transition-to-scikit-build branch from 96ba5b4 to 8fcf5e4 Compare September 17, 2024 15:22
Introduce conda-recipe-cf which does not depend on numpy-base.
Use it in conda-packages workflow to enable building for wider
range of Python versions than what is included in IDP.
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the transition-to-scikit-build branch 3 times, most recently from 90cac76 to 057600e Compare September 18, 2024 14:24
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the transition-to-scikit-build branch from 057600e to aa3876f Compare September 18, 2024 14:38
Copy link
Contributor

@AndresGuzman-Ballen AndresGuzman-Ballen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me!

conda-recipe-cf/build.sh Outdated Show resolved Hide resolved
conda-recipe-cf/build.sh Outdated Show resolved Hide resolved
conda-recipe/build.sh Outdated Show resolved Hide resolved
@oleksandr-pavlyk oleksandr-pavlyk merged commit 0eb645b into main Sep 24, 2024
12 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the transition-to-scikit-build branch September 24, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants