-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition from numpy.distutils to scikit-build #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation to switch from using deprecated ICC to its successor ICX, changed build system from deprecated numpy.distutils to scikit-build. Renamed files: loops_intel -> mkl_umath_loops Bumped up the version of the package from 0.1.1 to 0.1.2 Co-authored-by: Oleksandr Pavlyk <[email protected]> Co-authored-by: Andres Guzman-Ballen <[email protected]>
Used Python_add_library, instead of removed add_library followed by python_extension_module function from scikit-build. Removed superfluous comments
Some loops are not vectorized due to compiler's cost model analysis. Added CMake option OPTIMIZATION_REPORT (OFF by default). It would instruct compiler to generate optimization report for mkl_umath library.
Add high precision compiler flags
Replace test_basic with pytest
Convert the generated integer to numpy.int64 using type
Adjust variables after move to use NumPy as Python component
96ba5b4
to
8fcf5e4
Compare
Introduce conda-recipe-cf which does not depend on numpy-base. Use it in conda-packages workflow to enable building for wider range of Python versions than what is included in IDP.
90cac76
to
057600e
Compare
057600e
to
aa3876f
Compare
AndresGuzman-Ballen
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me!
ekomarova
reviewed
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation to switch from using deprecated ICC to its successor ICX, changed build system from deprecated numpy.distutils to scikit-build.
Renamed files: loops_intel -> mkl_umath_loops
Bumped up the version of the package from 0.1.1 to 0.1.2