Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document class World #14

Open
vilarion opened this issue Jul 15, 2021 · 5 comments
Open

Document class World #14

vilarion opened this issue Jul 15, 2021 · 5 comments
Assignees
@brightrim
Labels
documentation Improvements or additions to documentation

Comments

@vilarion
Copy link
Member

Use old doc as reference, test everything.
Check binding for completeness.
@vilarion vilarion added the documentation Improvements or additions to documentation label Jul 15, 2021
brightrim added a commit to brightrim/Illarion-Lua that referenced this issue Jun 26, 2022
@brightrim
Document class world Illarion-eV#14
c72c8c2 
-Some missing documentation still
@brightrim
Copy link
Member

Found a few missing in the old lua documentation that I have no idea how are supposed to work. Otherwise documented all that already existed in the old lua documentation.

@vilarion
Copy link
Member Author

Which ones are missing?

@brightrim
Copy link
Member

They are all in the documentation I pushed with a "???" where things like the explanation of what it does should be.

@vilarion vilarion mentioned this issue Jun 26, 2022
Closed
@vilarion
Copy link
Member Author

Can you create a pull request? I will review it and replace the "???" ones.

@vilarion
Copy link
Member Author

Never mind, I saw it went into your existing PR, since you used main as the base. I will handle it all in one, but feature branches are a better idea, usually.

brightrim added a commit to brightrim/Illarion-Lua that referenced this issue Jun 27, 2022
@brightrim
Document class world Illarion-eV#14
250794c 
-Some missing documentation still

(cherry picked from commit c72c8c2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brightrim brightrim

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vilarion @brightrim