Add wkdev-setup-default-clang script #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingPing
force-pushed
the
pgriffis/set-default-clang
branch
from
df8d268 to
6947e62
Compare
TingPing
changed the title
| ln -s "/usr/bin/${command}-18" "/usr/local/bin/${command}"; \ | ||
| done && ln -s "/usr/bin/lld-18" "/usr/local/bin/ld.lld"; | ||
| # Convenience symlinks for clang tools, the VSCode extension doesn't find these by default. | ||
| # FIXME: Reduce code duplication with `wkdev-set-default-clang`. |
There was a problem hiding this comment.
We should be able to invoke this script from here, no? Maybe at a later point in the script, but still..
There was a problem hiding this comment.
The wkdev-sdk scripts are not in the image. We could copy them and then remove them, feels not great either.
There was a problem hiding this comment.
As long as you copy and remove in the same layer, there is no increase an image size -- I agree looks odd, but helps reducing code duplication...
TingPing
force-pushed
the
pgriffis/set-default-clang
branch
2 times, most recently
from
52cc007 to
066cfa4
Compare
Closed
This allows easily installing and switching between different clang toolchains
TingPing
force-pushed
the
pgriffis/set-default-clang
branch
from
066cfa4 to
036dc5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows easily installing and switching between different clang toolchains