Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add exporter code to storage #7218

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Feb 12, 2025

What do these changes do?

Add functionality in the simcore_s3_dsm that allows to export an archive, given a list of S3 object_keys.

NOTE: currently the archive generation is faked out and will be added when #7186 is merged

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Feb 12, 2025
@GitHK GitHK added the a:storage issue related to storage service label Feb 12, 2025
@GitHK GitHK added this to the Singularity milestone Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.35%. Comparing base (4ca666e) to head (a4d6b01).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7218      +/-   ##
==========================================
+ Coverage   86.98%   88.35%   +1.36%     
==========================================
  Files        1667     1335     -332     
  Lines       64721    55284    -9437     
  Branches     1096      477     -619     
==========================================
- Hits        56299    48844    -7455     
+ Misses       8109     6311    -1798     
+ Partials      313      129     -184     
Flag Coverage Δ
integrationtests 68.42% <ø> (+3.13%) ⬆️
unittests 87.20% <93.10%> (+1.18%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.53% <100.00%> (ø)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.56% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.71% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.59% <ø> (ø)
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 89.77% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.08% <ø> (+0.10%) ⬆️
storage 87.27% <92.85%> (+0.71%) ⬆️
webclient ∅ <ø> (∅)
webserver 84.83% <ø> (+0.09%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca666e...a4d6b01. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant