Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(meta_refresh_delay | meta_redirect_optional) Fix the rules to align with ACT #2163

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Jan 24, 2025

  • Rule bug: meta_refresh_delay | meta_redirect_optional

This PR is related to the following issue(s):

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

@shunguoy shunguoy marked this pull request as ready for review January 24, 2025 14:36
Copy link
Member

@tombrunet tombrunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to not have 4.x content merging into 3.x

Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome and Firefox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment