Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.17] Fix notification settings creation #2287

Merged
merged 1 commit into from
Feb 25, 2025
Merged

[0.17] Fix notification settings creation #2287

merged 1 commit into from
Feb 25, 2025

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Feb 25, 2025 •
edited
Loading

Partial backport of #2283

Fixes Issue

Fixes #2281

Changes proposed

  • Ensure NotificatinServiceImpl create notification settings using persist rather than merge

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@lampajr
Fix notification settings creation
efdd98f 
Signed-off-by: Andrea Lamparelli <[email protected]>
@lampajr lampajr requested a review from barreiro February 25, 2025 17:40
@lampajr lampajr merged commit ec57e1c into Hyperfoil:0.17 Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barreiro barreiro barreiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lampajr @barreiro