Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support huge JSON data #2286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

diegolovison
Copy link
Contributor

Changes proposed

Support huge JSON data

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@lampajr lampajr self-requested a review February 26, 2025 08:19
Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @diegolovison, I did some tests and the changes are actually fixing the problem of uploading a big run but TBH I don't think we should set such defaults here.

Both can be added where needed at runtime (and if and only if are needed):

  • Server side: quarkus.http.limits.max-body-size=300M can be passed as JVM option when starting the server (i.e., we can do that in out internal lab for instance)
  • Client side: org.jboss.resteasy.client.jaxrs.engines.fileUploadInMemoryThreshold can be set before creating the HorreumClient, so that if users need that can do on their own and have a way to configure it. If we hardcode that users CANNOT override that value

@diegolovison
Copy link
Contributor Author

Server side: quarkus.http.limits.max-body-size=300M can be passed as JVM option when starting the server (i.e., we can do that in out internal lab for instance)

what is the limit on the database?

@lampajr
Copy link
Member

lampajr commented Feb 26, 2025

Server side: quarkus.http.limits.max-body-size=300M can be passed as JVM option when starting the server (i.e., we can do that in out internal lab for instance)

what is the limit on the database?

Don't remember exactly (need to check), but we should try to keep the json objects as smaller as possible for performance reasons.. therefore I would prefer to keep a lower limit by default - that's why I don't think increasing the quarkus max body limit is the good choice here (at least for the defaults)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants