gempyor API docstring refurbishment
#468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mprzy/flepiMoP into gempyor-docstring-improvements
TimothyWillard
added
gempyor
TimothyWillard
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Overall looks good, I think an improvement over the current state. A few themes:
- What's up with putting the file name as the header of a module docstrings? Seems redundant.
- There are some typing signatures that are off, I'd rather have no type signature than an incorrect one so if it's not clear let's leave it for another PR.
- There were some docstrings of CLI commands that were edited in ways that I think will look off when using
--help, I think we need to be careful about not applying the same docstring style to click commands.
|
This PR can also be used to address GH #431 . |
pearsonca
reviewed
Jan 30, 2025
pearsonca
approved these changes
Jan 31, 2025
TimothyWillard
approved these changes
Jan 31, 2025
Comment on lines
+715
to
+717
| def parse_parameters( | ||
| self, parameters: np.ndarray, parameter_names: list, unique_strings: list | ||
| ) -> np.ndarray: |
There was a problem hiding this comment.
Sorry, realizing I did not reply, not complete is better, we can go back and complete the picture later.
Co-authored-by: Carl A. B. Pearson <[email protected]>
Co-authored-by: Timothy Willard <[email protected]>
Co-authored-by: Timothy Willard <[email protected]>
Co-authored-by: Timothy Willard <[email protected]>
Co-authored-by: Timothy Willard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes.
This pull request:
gempyorgempyor, it does not propagate poor documentationAs I see it, the
gempyorAPI mainly consists of:ModelInfoclass frommodel_info.pyParametersclass fromparameters.py, and some associated methodsGempyorInferenceclass frominference.py, and some associated methodsCompartmentsclass fromcompartments.py, and some associated methodsutils.py(read_dfandwrite_df)Note, before narrowing my focus on guidance from Carl, I also wrote some docstring in two files (
calibrate.pyandcli.py). I do not think of these as being integral parts of thegempyorAPI, but because I worked on them in in the same sweep of work that I worked on the others, they are also included in this PR with some docstring improvements.What does your pull request address? Tag relevant issues.
This pull request addresses GH #462.