Don’t prefetch greedy outdated casks

[jneubrand]

In some instances, calling .outdated?(greedy: true) causes additional network requests. (casks using version :latest and sha256 :no_check seem to trigger this)

Currently, this is done for all installed packages every time brew bundle wants to update any cask greedily.

This pull request changes bundle's behavior to only check whether one cask is outdated at a time (for greedy updates).

[MikeMcQuaid]

This pull request changes bundle's behavior to only check whether one cask is outdated at a time (for greedy updates).

Can you explain why this is better?

What network requests does this avoid?

[jneubrand]

Can you explain why this is better?

What network requests does this avoid?

For all of the following casks…

grep -IirE '^ +version :latest' -A 1 /usr/local/Homebrew/Library/Taps | grep 'sha256 :no_check' -B 1

(a few dozen nightlies from homebrew-cask-versions, but also many homebrew-fonts)

…the entire current file has to be downloaded every time to check whether the contents that would be installed are equivalent.

---

Thanks for the notes, I don't deal with ruby often 😅

[MikeMcQuaid]

…the entire current file has to be downloaded every time to check whether the contents that would be installed are equivalent.

Yeh, this is expected when using --greedy. What's not clear though is how your PR makes this different?

Does this mean that brew bundle will behave the same if your Brewfile lists all installed casks but if it only has e.g. one cask it'll only download that one whereas before it would download them all?

[jneubrand]

… brew bundle will behave the same if your Brewfile lists all installed casks but if it only has e.g. one cask it'll only download that one whereas before it would download them all?

Well, it won’t download a cask without the greedy: true flag anymore. If you only set that flag on some casks, or if you don’t list that kind of cask at all, this PR speeds brew bundle. (edit: so yes, if you have a single line in your Brewfile with greedy: true, only that one will be downloaded)

[MikeMcQuaid]

don’t list that kind of cask at all, this PR speeds brew bundle

If you don't use greedy in your cask file at all: it wasn't being used already.

So is it now that greedy will only check specific casks greedily rather than any cask being greedy triggering checking all casks greedily?

[jneubrand]

don’t list that kind of cask at all, this PR speeds brew bundle

If you don't use greedy in your cask file at all: it wasn't being used already.

So is it now that greedy will only check specific casks greedily rather than any cask being greedy triggering checking all casks greedily?

Yup!

[MikeMcQuaid]

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @jneubrand!