fix(apidoc): Make type parameter optional in apidoc as in description #15194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, in the code below it is optional as well! @SabreCat LGTM |
|
This looks good to me; all it does is add a set of brackets in order to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes asmfreak/habitipy#25
Changes
This change is required for habitipy (a Python api client for Habitica). It parses the apidoc comments in Habitica code and makes and coding interface out of it. This change makes
typequery parameter optional not only in param's description, but also in apidoc code.UUID: 1f740057-8e11-4ca3-a9b2-54886615dca6