Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add info tab to bottom table. #904

Merged
merged 29 commits into from
Jan 21, 2025
Merged

Feature: Add info tab to bottom table. #904

merged 29 commits into from
Jan 21, 2025

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Dec 28, 2024

Description

This PR adds info tab to the bottom tray table and add information texts for advertiser and publishers.

Relevant Technical Choices

Testing Instructions

  1. Open PA:EE tab and let the flow begin.
  2. Click on any "i" icon
  3. The tab should switch to "info" and information text appear as title.

Additional Information:

Screenshot/Screencast

image

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@mohdsayed mohdsayed modified the milestones: v0.13.0, v1.0 Jan 14, 2025
@mohdsayed mohdsayed self-assigned this Jan 14, 2025
@mohdsayed mohdsayed marked this pull request as ready for review January 21, 2025 10:47
@mohdsayed mohdsayed requested a review from mayan-000 January 21, 2025 11:02
@mayan-000
Copy link
Collaborator

The Reset button doesn't reset the info tab.
(If intentional, ignore)

@mayan-000
Copy link
Collaborator

Click on the left side of the expand button (empty space), expands the animation.

Screen.Recording.2025-01-21.at.16.53.20.mov

Copy link
Collaborator

@mayan-000 mayan-000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are required, LGTM!

@mohdsayed
Copy link
Collaborator Author

The Reset button doesn't reset the info tab. (If intentional, ignore)

Good catch. Fixed

@mohdsayed
Copy link
Collaborator Author

Click on the left side of the expand button (empty space), expands the animation.

Screen.Recording.2025-01-21.at.16.53.20.mov

We will fix it separately, as it's not related to this PR.
cc: @milindmore22

@mohdsayed mohdsayed merged commit c84c6c0 into develop Jan 21, 2025
6 checks passed
@mohdsayed mohdsayed deleted the feat/ee-info branch January 21, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants