Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(lighthouse-stack-packs): upgrade to 1.10.0 #15038

Merged
merged 1 commit into from
May 3, 2023
Merged

deps(lighthouse-stack-packs): upgrade to 1.10.0 #15038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/lib/stack-packs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ import * as i18n from './i18n/i18n.js';
* @type {Array<{packId: string, requiredStacks: Array<string>}>}
*/
const stackPacksToInclude = [
{
packId: 'gatsby',
requiredStacks: ['js:gatsby'],
},
{
packId: 'wordpress',
requiredStacks: ['js:wordpress'],
Expand Down
8 changes: 8 additions & 0 deletions core/scripts/i18n/collect-strings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,8 +730,16 @@ function checkKnownFixedCollisions(strings) {
'Potential Savings',
'The page was evicted from the cache to allow another page to be cached.',
'The page was evicted from the cache to allow another page to be cached.',
'Use $MARKDOWN_SNIPPET_0$ to detect unused JavaScript code. $LINK_START_0$Learn more$LINK_END_0$',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few of these look like it's a waste to translate twice. e.g.

https://github.com/GoogleChrome/lighthouse-stack-packs/blob/db09b8af572e9041f8da7ce1aa608467a43626b6/packs/gatsby.js#LL12C7-L12C147

and

https://github.com/GoogleChrome/lighthouse-stack-packs/blob/db09b8af572e9041f8da7ce1aa608467a43626b6/packs/next.js#LL12C7-L12C147

are already the same, just the gatsby one is missing the trailing .

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a note for this here GoogleChrome/lighthouse-stack-packs#94

'Use $MARKDOWN_SNIPPET_0$ to detect unused JavaScript code. $LINK_START_0$Learn more$LINK_END_0$',
'Use the $MARKDOWN_SNIPPET_0$ component and set the appropriate $MARKDOWN_SNIPPET_1$. $LINK_START_0$Learn more$LINK_END_0$.',
'Use the $MARKDOWN_SNIPPET_0$ component and set the appropriate $MARKDOWN_SNIPPET_1$. $LINK_START_0$Learn more$LINK_END_0$.',
'Use the $MARKDOWN_SNIPPET_0$ component instead of $MARKDOWN_SNIPPET_1$ to adjust image quality. $LINK_START_0$Learn more$LINK_END_0$.',
'Use the $MARKDOWN_SNIPPET_0$ component instead of $MARKDOWN_SNIPPET_1$ to adjust image quality. $LINK_START_0$Learn more$LINK_END_0$.',
'Use the $MARKDOWN_SNIPPET_0$ component instead of $MARKDOWN_SNIPPET_1$ to automatically lazy-load images. $LINK_START_0$Learn more$LINK_END_0$.',
'Use the $MARKDOWN_SNIPPET_0$ component instead of $MARKDOWN_SNIPPET_1$ to automatically lazy-load images. $LINK_START_0$Learn more$LINK_END_0$.',
'Use the $MARKDOWN_SNIPPET_0$ component instead of $MARKDOWN_SNIPPET_1$ to automatically optimize image format. $LINK_START_0$Learn more$LINK_END_0$.',
'Use the $MARKDOWN_SNIPPET_0$ component instead of $MARKDOWN_SNIPPET_1$ to automatically optimize image format. $LINK_START_0$Learn more$LINK_END_0$.',
]);
} catch (err) {
console.log('The number of duplicate strings has changed. Consider duplicating the `description` to match existing strings so they\'re translated together or update this assertion if they must absolutely be translated separately');
Expand Down
15 changes: 15 additions & 0 deletions core/test/lib/stack-packs-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Array [
"angular",
"drupal",
"ezoic",
"gatsby",
"joomla",
"magento",
"next.js",
Expand Down Expand Up @@ -111,6 +112,20 @@ Array [
"font-display",
],
},
Object {
"id": "gatsby",
"keys": Array [
"unused-css-rules",
"modern-image-formats",
"offscreen-images",
"render-blocking-resources",
"unused-javascript",
"uses-long-cache-ttl",
"uses-optimized-images",
"uses-responsive-images",
"prioritize-lcp-image",
],
},
Object {
"id": "joomla",
"keys": Array [
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@
"jpeg-js": "^0.4.4",
"js-library-detector": "^6.6.0",
"lighthouse-logger": "^1.3.0",
"lighthouse-stack-packs": "1.9.1",
"lighthouse-stack-packs": "1.10.0",
"lodash": "^4.17.21",
"lookup-closest-locale": "6.2.0",
"metaviewport-parser": "0.3.0",
Expand Down
27 changes: 27 additions & 0 deletions shared/localization/locales/en-US.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 27 additions & 0 deletions shared/localization/locales/en-XL.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5117,10 +5117,10 @@ lighthouse-plugin-soft-navigation@^1.0.1:
resolved "https://registry.yarnpkg.com/lighthouse-plugin-soft-navigation/-/lighthouse-plugin-soft-navigation-1.0.1.tgz#82fb2008991458d753a819dd3e1f076d55eb2bfb"
integrity sha512-lvwiC9Bp/kzx7WTsPw/tjv1MkeRnvX2rKNTHDBSOOPYLsvaPrnaCk+6n+1sfinwLM6LAAWp5B9mTdi+G/31iDQ==

lighthouse-stack-packs@1.9.1:
version "1.9.1"
resolved "https://registry.yarnpkg.com/lighthouse-stack-packs/-/lighthouse-stack-packs-1.9.1.tgz#e83f76e302cb3dec717ad6a3af2da07c91d8f8f5"
integrity sha512-9prq6oMkVHz3GeCkphq4FHXXdj3M/WPiFWUvJAczLYV8j/oTxsgiHSPMqh1KVV11CP0VTxD40hFC0pDfXF+khQ==
lighthouse-stack-packs@1.10.0:
version "1.10.0"
resolved "https://registry.yarnpkg.com/lighthouse-stack-packs/-/lighthouse-stack-packs-1.10.0.tgz#1036db27deb27506012e767202489689524a26e9"
integrity sha512-5nvJS+IkZUbnDpIeJLi1xdnCfftBFMkxXfA5HHlEC1EQFQ2a8YPos6vl11oERHuIlDFEnVkaOeNaSIrL2K/9Gg==

lines-and-columns@^1.1.6:
version "1.2.4"
Expand Down