Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chrome.power/keep awake as an api sample #1060

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Conversation

patrickkettner
Copy link
Collaborator

@patrickkettner patrickkettner commented Jan 1, 2024

This is an existing extension that was previously hosted on chromium.org. It has
~400k users, but had been orphaned over the years. I took it over to migrate to
Manifest v3. Given we are hosting the code for the Font Settings extension, and
we don't have a chrome.power sample, I thought it made sense to host the code
here.

Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, let me know when you've tweaked and I can test and approve :)

api-samples/power/README.md Outdated Show resolved Hide resolved
api-samples/power/README.md Outdated Show resolved Hide resolved
api-samples/power/manifest.json Show resolved Hide resolved
Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one more comment, otherwise I tested this and it looks good so I'm happy.

.repo/sample-list-generator/src/utils/manifest.ts Outdated Show resolved Hide resolved
Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM.

.repo/sample-list-generator/src/utils/manifest.ts Outdated Show resolved Hide resolved
@patrickkettner patrickkettner merged commit 2a3e3d4 into main Jan 16, 2024
4 checks passed
@patrickkettner patrickkettner deleted the keep-awake branch January 16, 2024 12:48
@NicholaiMM
Copy link

Let's make a Chrome extension that allows you to use a menu and hotkeys to insert commonly used text such as intros, commands, and signatures. I found Ganpati internal tool at Google very useful but it's only available to Google employees with an email ending in @google.com

An example of the type of simple signature that could be with a simple dropdown menu when you click the extension is a simple signature you use across multiple sites, such as the following:

Thank you and kind regards,

Nicholai Maro Madias
Network Administrator
‪(727) 370-3006‬
[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants