Refactor/cliente cambiar campo address

app/models.py

@@ -1,14 +1,18 @@
 from django.db import models
 from datetime import datetime
 
-
+class CityEnum(models.TextChoices):
+    LA_PLATA = 'La Plata',
+    BERISSO = 'Berisso',
+    ENSENADA = 'Ensenada',
 
 def validate_client(data):
     errors = {}
 
     name = data.get("name", "")
     phone = data.get("phone", "")
     email = data.get("email", "")
+    city = data.get("city", "")
 
     if name == "":
         errors["name"] = "Por favor ingrese un nombre"
@@ -21,14 +25,19 @@ def validate_client(data):
     elif email.count("@") == 0:
         errors["email"] = "Por favor ingrese un email valido"
 
+    if city == "" or city is None:
+        errors["city"] = "Por favor ingrese una ciudad"
+    elif city not in dict(CityEnum.choices):
+        errors["city"] = "Por favor ingrese una ciudad valida"
+
     return errors
 
 
 class Client(models.Model):
     name = models.CharField(max_length=100)
     phone = models.CharField(max_length=15)
     email = models.EmailField()
-    address = models.CharField(max_length=100, blank=True)
+    city = models.CharField(max_length=35, choices=CityEnum.choices)
 
     def __str__(self):
         return self.name
@@ -44,19 +53,26 @@ def save_client(cls, client_data):
             name=client_data.get("name"),
             phone=client_data.get("phone"),
             email=client_data.get("email"),
-            address=client_data.get("address"),
+            city=client_data.get("city"),
         )
 
         return True, None
 
     def update_client(self, client_data):
+        errors = validate_client(client_data)
+
+        if len(errors.keys()) > 0:
+            return False, errors
+
         self.name = client_data.get("name", "") or self.name
         self.email = client_data.get("email", "") or self.email
         self.phone = client_data.get("phone", "") or self.phone
-        self.address = client_data.get("address", "") or self.address
+        self.city = client_data.get("city", "") or self.city
 
         self.save()
 
+        return True, None
+
 def validate_provider(data):
     errors = {}
 

app/templates/clients/form.html

@@ -66,18 +66,21 @@ <h1>Nuevo Cliente</h1>
                     {% endif %}
                 </div>
                 <div>
-                    <label for="address" class="form-label">Dirección</label>
-                    <input type="text"
-                        id="address"
-                        name="address"
-                        value="{{client.address}}"
-                        class="form-control" />
-
-                    <div class="invalid-feedback">
-                        La dirrección es opcional
-                    </div>
+                    <label for="city" class="form-label">Ciudad</label>
+                    <select id="city" name="city" class="form-select" required>
+                        <option value="" disabled selected>Seleccione una ciudad</option>
+                        {% for id_city, city in ciudades %}
+                            <option value="{{ id_city }}" {% if client.city == id_city %}selected{% endif %}>
+                                {{ city }}
+                            </option>
+                        {% endfor %}
+                    </select>
+                    {% if errors.city %}
+                    <div class="invalid-feedback">{{ errors.city }}</div>
+                    {% endif %}
                 </div>
 
+
                 <button class="btn btn-primary">Guardar</button>
             </form>
         </div>

app/templates/clients/repository.html

@@ -17,7 +17,7 @@ <h1 class="mb-4">Clientes</h1>
                 <th>Nombre</th>
                 <th>Teléfono</th>
                 <th>Email</th>
-                <th>Dirección</th>
+                <th>Ciudad</th>
                 <th></th>
             </tr>
         </thead>
@@ -28,7 +28,7 @@ <h1 class="mb-4">Clientes</h1>
                     <td>{{client.name}}</td>
                     <td>{{client.phone}}</td>
                     <td>{{client.email}}</td>
-                    <td>{{client.address}}</td>
+                    <td>{{client.city}}</td>
                     <td>
                         <a class="btn btn-outline-primary"
                            href="{% url 'clients_edit' id=client.id %}"

app/tests_integration.py

@@ -27,22 +27,22 @@ def test_form_use_form_template(self):
         self.assertTemplateUsed(response, "clients/form.html")
 
     def test_can_create_client(self):
+
         response = self.client.post(
             reverse("clients_form"),
             data={
                 "name": "Juan Sebastian Veron",
-                "phone": "221555232",
-                "address": "13 y 44",
-                "email": "[email protected]",
+                "phone": "54221555232",
+                "email": "[email protected]",
+                "city": "La Plata",
             },
         )
         clients = Client.objects.all()
         self.assertEqual(len(clients), 1)
-
         self.assertEqual(clients[0].name, "Juan Sebastian Veron")
-        self.assertEqual(clients[0].phone, "221555232")
-        self.assertEqual(clients[0].address, "13 y 44")
-        self.assertEqual(clients[0].email, "[email protected]")
+        self.assertEqual(clients[0].phone, "54221555232")
+        self.assertEqual(clients[0].email, "[email protected]")
+        self.assertEqual(clients[0].city, "La Plata")
 
         self.assertRedirects(response, reverse("clients_repo"))
 
@@ -55,6 +55,7 @@ def test_validation_errors_create_client(self):
         self.assertContains(response, "Por favor ingrese un nombre")
         self.assertContains(response, "Por favor ingrese un teléfono")
         self.assertContains(response, "Por favor ingrese un email")
+        self.assertContains(response, "Por favor ingrese una ciudad")
 
     def test_should_response_with_404_status_if_client_doesnt_exists(self):
         response = self.client.get(reverse("clients_edit", kwargs={"id": 100}))
@@ -66,37 +67,68 @@ def test_validation_invalid_email(self):
             data={
                 "name": "Juan Sebastian Veron",
                 "phone": "221555232",
-                "address": "13 y 44",
+                "city": "La Plata",
                 "email": "brujita75",
             },
         )
 
         self.assertContains(response, "Por favor ingrese un email valido")
 
-    def test_edit_user_with_valid_data(self):
+    def test_edit_user_with_valid_data_test(self):
+        """"
+        test para editar un cliente con datos validos.
+        """
         client = Client.objects.create(
-            name="Juan Sebastián Veron",
-            address="13 y 44",
-            phone="221555232",
-            email="brujita75@hotmail.com",
+            name="Guido Carrillo",
+            city="La Plata",
+            phone="54221555232",
+            email="guido@vetsoft.com",
         )
 
         response = self.client.post(
             reverse("clients_form"),
-            data={
+              data={
                 "id": client.id,
-                "name": "Guido Carrillo",
+                "name": "Juan Sebastian Veron",
+                "phone": "221456789",
+                "email": "[email protected]",
+                "city": "Berisso",
             },
         )
 
         # redirect after post
         self.assertEqual(response.status_code, 302)
 
         editedClient = Client.objects.get(pk=client.id)
-        self.assertEqual(editedClient.name, "Guido Carrillo")
-        self.assertEqual(editedClient.phone, client.phone)
-        self.assertEqual(editedClient.address, client.address)
-        self.assertEqual(editedClient.email, client.email)
+        self.assertEqual(editedClient.name, "Juan Sebastian Veron")
+        self.assertEqual(editedClient.email, "[email protected]")
+        self.assertEqual(editedClient.phone, "221456789")
+        self.assertEqual(editedClient.city, "Berisso")
+
+    def test_edit_user_with_invalid_data_test_city(self):
+
+        client = Client.objects.create(
+            name="Guido Carrillo",
+            city="La Plata",
+            phone="221456789",
+            email="[email protected]",
+        )
+
+
+        self.client.post(
+            reverse("clients_form"),
+            data={
+                "id": client.id,
+                "name": "Juan Sebastian Veron",
+                "phone": "221456789",
+                "city": "Rosario",
+                "email": "[email protected]",
+            },
+        )
+
+        # redirect after post
+        editedClient = Client.objects.get(pk=client.id)
+        self.assertEqual(editedClient.city, "La Plata")
 
 class MedicineIntegrationTest(TestCase):
     def test_can_create_medicine(self):

app/tests_unit.py

@@ -8,44 +8,50 @@ def test_can_create_and_get_client(self):
             {
                 "name": "Juan Sebastian Veron",
                 "phone": "221555232",
-                "address": "13 y 44",
-                "email": "brujita75@hotmail.com",
+                "city": "La Plata",
+                "email": "brujita75@vetsoft.com",
             }
         )
         clients = Client.objects.all()
         self.assertEqual(len(clients), 1)
 
         self.assertEqual(clients[0].name, "Juan Sebastian Veron")
         self.assertEqual(clients[0].phone, "221555232")
-        self.assertEqual(clients[0].address, "13 y 44")
-        self.assertEqual(clients[0].email, "brujita75@hotmail.com")
+        self.assertEqual(clients[0].city, "La Plata")
+        self.assertEqual(clients[0].email, "brujita75@vetsoft.com")
 
     def test_can_update_client(self):
+
         Client.save_client(
             {
                 "name": "Juan Sebastian Veron",
                 "phone": "221555232",
-                "address": "13 y 44",
-                "email": "[email protected]",
-            }
+                "email": "[email protected]",
+                "city": "La Plata",
+            },
         )
         client = Client.objects.get(pk=1)
 
-        self.assertEqual(client.phone, "221555232")
-
-        client.update_client({"phone": "221555233"})
+        client.update_client(  {
+                "name": "Juan Sebastian Veron",
+                "phone": "221555232",
+                "email": "[email protected]",
+                "city": "Berisso",
+            },)
 
         client_updated = Client.objects.get(pk=1)
 
-        self.assertEqual(client_updated.phone, "221555233")
+        self.assertEqual(client_updated.phone, "221555232")
+        self.assertEqual(client_updated.email, "[email protected]")
+        self.assertEqual(client_updated.city, "Berisso")
 
     def test_update_client_with_error(self):
         Client.save_client(
             {
                 "name": "Juan Sebastian Veron",
                 "phone": "221555232",
-                "address": "13 y 44",
-                "email": "brujita75@hotmail.com",
+                "city": "La Plata",
+                "email": "brujita75@vetsoft.com",
             }
         )
         client = Client.objects.get(pk=1)
@@ -112,7 +118,7 @@ def test_can_create_and_get_provider(self):
         Provider.save_provider(
             {
                 "name": "Juan Roman Riquelme",
-                "email": "senor10@gmail.com",
+                "email": "senor10@vetsoft.com",
                 "address": "13 y 44",
             }
         )
@@ -121,15 +127,15 @@ def test_can_create_and_get_provider(self):
 
         self.assertEqual(providers[0].name, "Juan Roman Riquelme")
         self.assertEqual(providers[0].address, "13 y 44")
-        self.assertEqual(providers[0].email, "senor10@gmail.com")
+        self.assertEqual(providers[0].email, "senor10@vetsoft.com")
 
     #Agrego test unitario especifico de la issue de provider
     def test_provider_address(self):
         addres = "calle 13 y 44"
         Provider.save_provider(
             {
                 "name": "Juan Roman Riquelme",
-                "email": "senor10@gmail.com",
+                "email": "senor10@vetsoft.com",
                 "address": addres, #guardo proveedor con direccion especifica
             }
         )

app/views.py

@@ -1,5 +1,5 @@
 from django.shortcuts import render, redirect, reverse, get_object_or_404
-from .models import Client, Provider, Product, Pet, Medicine, Veterinary
+from .models import Client, CityEnum, Provider, Product, Pet, Medicine, Veterinary
 
 def home(request):
     return render(request, "home.html")
@@ -11,6 +11,7 @@ def clients_repository(request):
 
 
 def clients_form(request, id=None):
+    ciudades = CityEnum.choices
     if request.method == "POST":
         client_id = request.POST.get("id", "")
         errors = {}
@@ -20,20 +21,20 @@ def clients_form(request, id=None):
             saved, errors = Client.save_client(request.POST)
         else:
             client = get_object_or_404(Client, pk=client_id)
-            client.update_client(request.POST)
+            saved,errors = client.update_client(request.POST)
 
         if saved:
             return redirect(reverse("clients_repo"))
 
         return render(
-            request, "clients/form.html", {"errors": errors, "client": request.POST}
+            request, "clients/form.html", {"errors": errors, "client": request.POST, "ciudades": ciudades},
         )
 
     client = None
     if id is not None:
         client = get_object_or_404(Client, pk=id)
 
-    return render(request, "clients/form.html", {"client": client})
+    return render(request, "clients/form.html", {"client": client, "ciudades": ciudades})
 
 
 def clients_delete(request):