Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#48) design system refactoring #53

Merged
merged 8 commits into from
Dec 6, 2024
Merged

๐Ÿ”€ :: (#48) design system refactoring #53

merged 8 commits into from
Dec 6, 2024

Conversation

ImGaram
Copy link
Member

@ImGaram ImGaram commented Dec 3, 2024 •
edited
Loading

๐Ÿ“Œ ๊ฐœ์š”

  • ๋””์ž์ธ ์‹œ์Šคํ…œ ๋ฆฌํŒฉํ† ๋ง.

๐Ÿ”€ ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • ์—†๋Š” ์ƒ‰ ์ถ”๊ฐ€.
  • gosocketdialog button์„ GoSocketButton์œผ๋กœ ๋ณ€๊ฒฝ.
  • ๋””์ž์ธ์— ์—†๋Š” textfield ์‚ญ์ œ.
  • ์ปดํฌ๋„ŒํŠธ ์ƒ‰์„ ๋””์ž์ธ ์‹œ์Šคํ…œ์˜ color๋กœ ๋ณ€๊ฒฝ.
  • invitetextfield placeholder ๋ณ€๊ฒฝ ๋ฐ contentpadding ํŒŒ๋ผ๋ฏธํ„ฐ ์ถ”๊ฐ€.

๐Ÿ“ธ ๊ตฌํ˜„ ํ™”๋ฉด or ๊ตฌํ˜„ ์˜์ƒ

image
image
image

@ImGaram ImGaram added 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ - ์ƒ ๐Ÿ”จ Type: Refector ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง labels Dec 3, 2024
@ImGaram ImGaram self-assigned this Dec 3, 2024
@ImGaram ImGaram linked an issue Dec 3, 2024 that may be closed by this pull request
(#48) ๋””์ž์ธ ์‹œ์Šคํ…œ ๋ฆฌํŒฉํ† ๋ง #48
Closed
2 tasks
wjdalsths
wjdalsths approved these changes Dec 3, 2024
View reviewed changes
Copy link

@wjdalsths wjdalsths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ImGaram ImGaram changed the title Feature/design system refactor ๐Ÿ”€ :: (#48) design system refactoring Dec 3, 2024
Cjsghkd
Cjsghkd approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@Cjsghkd Cjsghkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ถ”๊ฐ€ํ•ด์„œ ์ด์ œ ๊ตฌํ˜„ ๊ฐ€๋Šฅํ•œ ์ปดํฌ๋„ŒํŠธ ์‚ฌ์ง„๋„ ํ•œ๋ฒˆ ์˜ฌ๋ ค์ฃผ๋ฉด Preview๋กœ ํ•ด์„œ ๋ณด์—ฌ์ฃผ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

@ImGaram
Copy link
Member Author

ImGaram commented Dec 4, 2024

์ถ”๊ฐ€ํ•ด์„œ ์ด์ œ ๊ตฌํ˜„ ๊ฐ€๋Šฅํ•œ ์ปดํฌ๋„ŒํŠธ ์‚ฌ์ง„๋„ ํ•œ๋ฒˆ ์˜ฌ๋ ค์ฃผ๋ฉด Preview๋กœ ํ•ด์„œ ๋ณด์—ฌ์ฃผ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

๋ณ€๊ฒฝ๋œ component๋“ค(๋‹จ์ˆœ ์ƒ‰์ƒ ์žฌ์ ์šฉ์€ ์ œ์™ธ)์˜ ์‚ฌ์ง„๋“ค์„ ์˜ฌ๋ ธ์œผ๋‹ˆ ํ™•์ธ ํ•ด์ฃผ์„ธ์š”.

@ImGaram ImGaram merged commit 8487f69 into develop Dec 6, 2024
1 check passed
@ImGaram ImGaram deleted the feature/design_system_refactor branch December 6, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cjsghkd Cjsghkd Cjsghkd approved these changes

@Hyeonseo4799 Hyeonseo4799 Hyeonseo4799 approved these changes

@wjdalsths wjdalsths wjdalsths approved these changes

Assignees

@ImGaram ImGaram

Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ - ์ƒ ๐Ÿ”จ Type: Refector ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(#48) ๋””์ž์ธ ์‹œ์Šคํ…œ ๋ฆฌํŒฉํ† ๋ง
4 participants
@ImGaram @Cjsghkd @Hyeonseo4799 @wjdalsths