Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AND-277] Avatar component factories #5596

Merged
merged 18 commits into from
Feb 4, 2025

Conversation

andremion
Copy link
Collaborator

@andremion andremion commented Jan 28, 2025

🎯 Goal

Provide default factories for the avatar components: Avatar, UserAvatar, ChannelAvatar, and GroupAvatar

Unrelated changes

  • Add André Rêgo demo user.
  • Replace André Mion preview user with André Rêgo.
  • Factory for the channel list header.
  • Replace UserAvatar usages with Avatar when showOnlineIndicator = false, which means we can use Avatar directly.
  • Move logic of quoted message out of ChatComponentFactory.

🎨 UI Changes

Custom Avatar Custom ChannelAvatar
Screen_recording_20250131_162928.webm
Screen_recording_20250131_163229.webm
Custom GroupAvatar Custom UserAvatar
Screen_recording_20250131_163536.webm
Screen_recording_20250131_163758.webm

Copy link
Contributor

github-actions bot commented Jan 28, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.17 MB 3.17 MB 0.00 MB 🟢
stream-chat-android-offline 3.38 MB 3.38 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.86 MB 7.86 MB 0.00 MB 🟢
stream-chat-android-compose 8.73 MB 8.74 MB 0.00 MB 🟢

@andremion andremion force-pushed the AND-277-useravatar-stateless-component branch from a4cbedd to c98c7c8 Compare January 28, 2025 16:16
@andremion andremion marked this pull request as ready for review January 28, 2025 16:16
@andremion andremion requested a review from a team as a code owner January 28, 2025 16:16
@andremion andremion force-pushed the AND-277-useravatar-stateless-component branch from c98c7c8 to 2100b11 Compare January 29, 2025 08:36
@andremion andremion added enhancement New feature or request compose Jetpack Compose labels Jan 29, 2025
@andremion andremion force-pushed the AND-277-useravatar-stateless-component branch 2 times, most recently from 3ee688a to c9eb9df Compare January 31, 2025 14:53
@andremion andremion marked this pull request as draft January 31, 2025 14:54
@andremion andremion force-pushed the AND-277-useravatar-stateless-component branch from c9eb9df to 44388f2 Compare January 31, 2025 16:25
@andremion andremion marked this pull request as ready for review January 31, 2025 16:40
@andremion andremion force-pushed the AND-277-useravatar-stateless-component branch from 44388f2 to f705adf Compare February 3, 2025 08:50
@andremion andremion requested review from a team and removed request for aleksandar-apostolov and VelikovPetar February 3, 2025 09:12
@andremion andremion force-pushed the AND-277-useravatar-stateless-component branch from 9b3686e to 0c90e1a Compare February 3, 2025 12:56
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
54.1% Coverage on New Code (required ≥ 80%)
13.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@aleksandar-apostolov aleksandar-apostolov merged commit 79a043c into develop Feb 4, 2025
11 of 12 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the AND-277-useravatar-stateless-component branch February 4, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compose Jetpack Compose enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants