-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AND-277] Avatar component factories #5596
Merged
aleksandar-apostolov
merged 18 commits into
develop
from
AND-277-useravatar-stateless-component
Feb 4, 2025
Merged
[AND-277] Avatar component factories #5596
aleksandar-apostolov
merged 18 commits into
develop
from
AND-277-useravatar-stateless-component
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size Comparison 📏
|
a4cbedd
to
c98c7c8
Compare
c98c7c8
to
2100b11
Compare
3ee688a
to
c9eb9df
Compare
JcMinarro
reviewed
Jan 31, 2025
...pose/src/main/java/io/getstream/chat/android/compose/ui/channels/header/ChannelListHeader.kt
Outdated
Show resolved
Hide resolved
JcMinarro
reviewed
Jan 31, 2025
...-compose/src/main/java/io/getstream/chat/android/compose/ui/components/avatar/GroupAvatar.kt
Outdated
Show resolved
Hide resolved
c9eb9df
to
44388f2
Compare
44388f2
to
f705adf
Compare
VelikovPetar
reviewed
Feb 3, 2025
...o/getstream/chat/android/compose/ui/components/suggestions/mentions/MentionSuggestionItem.kt
Outdated
Show resolved
Hide resolved
9b3686e
to
0c90e1a
Compare
|
aleksandar-apostolov
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Provide default factories for the avatar components:
Avatar
,UserAvatar
,ChannelAvatar
, andGroupAvatar
Unrelated changes
UserAvatar
usages withAvatar
whenshowOnlineIndicator = false
, which means we can useAvatar
directly.🎨 UI Changes
Screen_recording_20250131_162928.webm
Screen_recording_20250131_163229.webm
Screen_recording_20250131_163536.webm
Screen_recording_20250131_163758.webm