Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update firefox note in jpegxl.json #6887

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Update firefox note in jpegxl.json #6887

merged 1 commit into from
Nov 8, 2023

Conversation

shellheim
Copy link
Contributor

Now jpegxl can be enabled in stable version of firefox also (not only in nightly) so the note should be updated.

Now jpegxl can be enabled in stable version of firefox also (not only in nightly)
@Fyrd Fyrd merged commit 2df88a2 into Fyrd:main Nov 8, 2023
1 check passed
@Fyrd
Copy link
Owner

Fyrd commented Nov 8, 2023

Thanks!

@shellheim shellheim deleted the patch-1 branch November 8, 2023 11:01
@tats-u
Copy link
Contributor

tats-u commented Nov 26, 2023

@shellheim You told a lie.
No task to link libjxl even in stable builds is not linked to https://bugzilla.mozilla.org/show_bug.cgi?id=1539075.
You must present evidence if you object.
JPEG XL is not enabled in stable builds even now!

image
image

@tats-u
Copy link
Contributor

tats-u commented Nov 26, 2023

In the first place, you must not overwrite the note for past versions just because of the current one.
You must copy its description and create a new note instead at least.

@shellheim
Copy link
Contributor Author

@tats-u My bad. I saw that the flag image.jxl.enabled was added back in the stable channel. I didn't know that it was not yet functional. I was using a fork and tested on that with the flag enabled and that worked so I made a quick PR. I should have tested on the official browser. Sorry for the trouble.

@shellheim
Copy link
Contributor Author

are you considering adding that the libjxl hasn't yet been linked in stable but the option is still in about:config in your revert PR (probably as a comment?) for future contributors who see that?

@tats-u
Copy link
Contributor

tats-u commented Nov 26, 2023

@shellheim

Only links and screenshots are our weapons.

I saw that the flag image.jxl.enabled was added back in the stable channel.

This is a typical pitfall. This does not make any effect in stable builds.

I was using a fork

You should provide more info on that. As far as I know, Waterfox and Pale Moon have supported.

the option is still in about:config

I will cover in that pitfall.

@shellheim
Copy link
Contributor Author

I was using librewolf. They used a patch to fix that and that wasn't in official firefox.

@tats-u
Copy link
Contributor

tats-u commented Nov 26, 2023

https://codeberg.org/librewolf/source/pulls/53
https://codeberg.org/librewolf/source/pulls/47

It was done by either of these PRs. They are independent on Firefox HQ, which uses Bugzilla as the bug tracker.
To raise another example, Edge is a Chromium fork but intentionally disables AV1 & AVIF. (This is because I hate Edge)

@shellheim
Copy link
Contributor Author

Yeah, I knew that. Sorry for the mistake and thanks for taking the time to find the PRs.

Fyrd pushed a commit that referenced this pull request Dec 5, 2023
…ll that the flag has no effect in the other builds than Nightly (#6909)

* Revert "update firefox note in  jpegxl.json (#6887)"

This reverts commit 2df88a2.

* Add note about flag having no effect in other builds than Nightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants