Add Pokeball animations #734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
requested changes
May 3, 2018
| /** | ||
| * Uses an item. | ||
| */ | ||
| export class Item<TGameStartr extends FullScreenPokemon> extends GeneralComponent<TGameStartr> { |
There was a problem hiding this comment.
It's confusing to me how this is called Item but refers to the animation (Move is also confusing, but I can fix that later). Let's rename it to ItemAnimation.
| this.teamAndAction = teamAndAction; | ||
| this.item = item; | ||
|
|
||
| const battleInfo: IBattleInfo = gameStarter.battleMover.getBattleInfo() as IBattleInfo; |
There was a problem hiding this comment.
Once this PR goes in, please file a followup issue to consolidate this class with the Move class. Not your responsibility, but it'll be good code cleanup.
IMO there should be one general class used for both.
| */ | ||
| public makeBattleBall(): IBattleBall { | ||
| let probability = 0; | ||
| if (this.item === "Poke") { //should this be Poke? |
There was a problem hiding this comment.
Tip: use an object of type { [i: string]: number } so you don't have to have multiple if/elses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It adds the animation to throw Pokeballs.
Note: My alignments aren't pixel perfect and my timing isn't necessarily down to the millisecond. I eyeballed them and left them when I felt they were good.
Fixes #733