chore: use GitHub application token #3616
Draft
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…se-github-application-token
|
Coverage Report:
Changed Files:
|
| @@ -17,10 +17,26 @@ jobs: | |||
| if: github.actor == 'dependabot[bot]' | |||
There was a problem hiding this comment.
What is happening in this workflow that requires an app token? It looks like it's only manipulating the contents of the current repo, which should be a matter of adjusting the existing token permissions, not using an app.
.github/workflows/release.yaml
Outdated
| @@ -109,7 +118,7 @@ jobs: | |||
| pnpm changeset publish --tag next | |||
| env: | |||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
There was a problem hiding this comment.
Most of these changes don't look like they need an app - only the stuff doing anything to other repos should need special access. The default token should work fine for changes to this repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GITHUB_TOKENusage to use an application token for cross-repository operations.Next steps
Create GitHub application (see here)
Actions:Read+Write(to trigger workflows onFuelLabs/docs-hub+FuelLabs/migrations-and-disclosures)Populate GitHub actions:
APP_ID(application ID)APP_PRIVATE_KEY(application private key)Checklist