Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please reupload 1.0.0 with latest package updates #141

Closed
furgo16 opened this issue Dec 23, 2024 · 16 comments
Closed

Please reupload 1.0.0 with latest package updates #141

furgo16 opened this issue Dec 23, 2024 · 16 comments

Comments

@furgo16
Copy link
Contributor

furgo16 commented Dec 23, 2024

There have been a couple of recent snap package updates that could be very beneficial to FreeCAD 1.0 users. In particular, the updates with packaging PRs fixing these bugs:

FreeCAD is currently one of the featured apps in Ubuntu: the App Center shows FreeCAD on the first page. Given that this would be a packaging change only (no FreeCAD code fixes), and the positive impact on UX, I feel the update might be worth considering.

An option to minimize risks could be to upload it to the candidate channel and request testers for feedback before updating the stable channel.

Captura de pantalla de 2024-12-23 12-49-08
Ubuntu's App Center featuring FreeCAD

@furgo16
Copy link
Contributor Author

furgo16 commented Dec 23, 2024

@luzpaz @chennes ^

@chennes
Copy link
Member

chennes commented Dec 23, 2024

Can you create a PR that backports the necessary commits to stable?

@furgo16
Copy link
Contributor Author

furgo16 commented Dec 23, 2024

Ah, I hadn't realized there was a stable branch in this project. Sure, thanks for the pointer!

@furgo16
Copy link
Contributor Author

furgo16 commented Dec 23, 2024

Done at #144

@chennes
Copy link
Member

chennes commented Dec 23, 2024

Merged, built, and promoted. Let me know if it works.

@furgo16
Copy link
Contributor Author

furgo16 commented Dec 23, 2024

Great, thanks! I updated my freecad_stable snap install from the candidate channel via:

snap refresh freecad_stable --channel=candidate
OS: Ubuntu Core 22 (ubuntu:GNOME/ubuntu/xcb)
Architecture: x86_64
Version: 1.0.0.38641 +468 (Git) Snap 1234
Build type: Release
Branch: tag: 1.0.0
Hash: 2fcc5317fe3aee96ca73475986a577719fc78e20
Python 3.10.12, Qt 5.15.10, Coin 4.0.0, Vtk 7.1.1, OCC 7.7.1
Stylesheet/Theme/QtStyle: OpenLight.qss/OpenLight/Qt default
Installed mods: 
  * OpenTheme 2024.9.1
  * BIM021 2021.12.0
  * Assembly4 0.50.15

After a cursory test, thumbnail previews now work again, as expected

@furgo16
Copy link
Contributor Author

furgo16 commented Dec 30, 2024

@luzpaz could you help with testing this 1.0.0 snap packaging update on the candidate channel? Thanks!

@luzpaz
Copy link
Collaborator

luzpaz commented Dec 30, 2024

Running candidate I see the following in the console:
QTextBrowser: No document for file:////snap/freecad/1234/usr/share/doc/FreeCAD//ThirdPartyLibraries.html

OS: Ubuntu Core 22 (KDE/plasma/xcb)
Architecture: x86_64
Version: 1.0.0.38641 +468 (Git) Snap 1234
Build type: Release
Branch: tag: 1.0.0
Hash: 2fcc5317fe3aee96ca73475986a577719fc78e20
Python 3.10.12, Qt 5.15.10, Coin 4.0.0, Vtk 7.1.1, OCC 7.7.1
Locale: English/United States (en_US)
Stylesheet/Theme/QtStyle: FreeCAD Dark.qss/FreeCAD Dark/Fusion

Edit: I wish the About info showed what Snap channel we're running (probably too much to ask)

@furgo16
Copy link
Contributor Author

furgo16 commented Dec 30, 2024

Thanks for testing. I've been seeing the same message on the edge channel snap for a while. I'll have to check whether it also appears for me in the stable channel. I don't know what causes it.

It'd be indeed great to see the channel in the about info, but I don't think it's available with the way we read the snap version from FreeCAD itset currently. As a workaround, the snap package number will tell you from where the snap comes from.

@furgo16
Copy link
Contributor Author

furgo16 commented Dec 30, 2024

Oh, I wonder if that message is a symptom of #135

@adrianinsaval
Copy link
Member

Edit: I wish the About info showed what Snap channel we're running (probably too much to ask)

what does the 1234 mean in the about info now? is there some environment variable we can check to know what channel is running?

@furgo16
Copy link
Contributor Author

furgo16 commented Dec 31, 2024

@furgo16
Copy link
Contributor Author

furgo16 commented Dec 31, 2024

@luzpaz is this good to go from your point of view?

I guess we should backport #147 to the stable branch as a separate PR + upload.

@luzpaz
Copy link
Collaborator

luzpaz commented Dec 31, 2024

@furgo16 do you mind making the PR to stable?

Please refresh my memory how to re-upload 1.0.0 backported changes ? I haven't done that in a while.

@furgo16
Copy link
Contributor Author

furgo16 commented Jan 8, 2025

@luzpaz I don't have visibility nor permissions on how snap builds for the stable channel are uploaded to the Snap Store. I can see from the GitHub Actions that daily builds are uploaded automatically, but I guess that stable builds are uploaded manually. The documentation seems to confirm that.

For this issue and associated PR #144, what I suggested was to upload the backported snap to the candidate channel first to allow for testing. If testing were to be successful, then the snap could be manually promoted to the stable channel. This is where we are now. The backported snap (1248) has been sitting on the candidate channel for a while. Unfortunately, the call for testing on the forum has not been too fruitful. We currently have no feedback from potential testers.

channels:
  latest/stable:    1.0.0         2024-11-21 (1202) 825MB - # => Snap not updated since 1.0.0 release date
  latest/candidate: 1.0.0         2025-01-03 (1248) 825MB - # => Snap updated with PR #144
  latest/beta:      1.1-ga974e413 2025-01-05 (1251) 799MB -
  latest/edge:      1.1-gc4203169 2025-01-08 (1255) 828MB -

For the latest backported PR #150, since it already includes PR #144 I guess the same procedure could be used (first upload to candidate, then to stable). @chennes was the one who did the upload to candidate the last time, so I guess he'd be the best person to ask.

Thanks!

@luzpaz
Copy link
Collaborator

luzpaz commented Jan 8, 2025

Thanks @furgo16
I promoted candidate to stable.

@luzpaz luzpaz closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants