Libraries information cant be seen at snap dev version (due to ThirdPartyLibraries.html not installing correctly)

[projectcad]

Is there an existing issue for this?

• I have searched the existing issues

Problem description

Libraries information cant be seen at snap dev version

Full version info

OS: Ubuntu Core 22 (X-Cinnamon/cinnamon/xcb)
Architecture: x86_64
Version: 1.1.0dev.39241 (Git) Snap 1198
Build type: Release
Branch: main
Hash: cdb92768fe4f33d900664415c613f9eced5b8927
Python 3.10.12, Qt 5.15.10, Coin 4.0.0, Vtk 7.1.1, OCC 7.7.1
Locale: English/United States (en_US)
Stylesheet/Theme/QtStyle: unset/unset/Qt default

Subproject(s) affected?

None

Anything else?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[maxwxyz]

@adrianinsaval FYI

[furgo16]

I can confirm

[furgo16]

See #141 (comment). Perhaps a missing file not being included in the snap package?

[luzpaz]

QTextBrowser: No document for file:////snap/freecad/1234/usr/share/doc/FreeCAD//ThirdPartyLibraries.html

In FreeCAD main there is a cmake file that directs the installation of this file:
https://github.com/FreeCAD/FreeCAD/blob/main/src/Doc/ThirdPartyLibraries.html.cmake

Need to check if this is missing.

Edit:

https://github.com/FreeCAD/FreeCAD/blob/e977eb49e37ef836f695809263fa1f56a17cc657/src/Gui/DlgAbout.cpp#L472-L473

void AboutDialog::showLibraryInformation()
{
    auto tab_library = new QWidget();
    tab_library->setObjectName(QString::fromLatin1("tab_library"));
    ui->tabWidget->addTab(tab_library, tr("Libraries"));
    auto hlayout = new QVBoxLayout(tab_library);
    auto textField = new QTextBrowser(tab_library);
    textField->setOpenExternalLinks(false);
    textField->setOpenLinks(false);
    hlayout->addWidget(textField);

    QString baseurl = QString::fromLatin1("file:///%1/ThirdPartyLibraries.html")
                          .arg(QString::fromStdString(App::Application::getHelpDir()));

    textField->setSource(QUrl(baseurl));
}

Edit2:

Looks like the directory it's installed into via cmake on Fedora gets removed

# Belongs in %%license not %%doc
rm -f %{buildroot}%{_docdir}/freecad/ThirdPartyLibraries.html

ref: https://github.com/FreeCAD/FreeCAD/blob/e977eb49e37ef836f695809263fa1f56a17cc657/package/fedora/freecad.spec#L278

[luzpaz]

file:////snap/freecad/1234/usr/share/doc/FreeCAD//ThirdPartyLibraries.html

I just searched my /snap/freecad/1234/usr/share/doc and there is no FreeCAD subdirectory in there. So we know that /snap/freecad/1234/usr/share/doc is legit and the place the snap is pointing to.

[luzpaz]

Where does the flatpak install ThirdPartyLibraries.html to ?
Any idea @adrianinsaval

[adrianinsaval]

Where does the flatpak install ThirdPartyLibraries.html to ? Any idea @adrianinsaval

/app/share/doc/FreeCAD/ThirdPartyLibraries.html

Looks like the directory it's installed into via cmake on Fedora gets removed

it probably shouldn't be, this was also a problem some time ago in the windows weekly and I had to make sure the files are shipped: FreeCAD/FreeCAD-Bundle@7ce4083

I don't know if the fedora spec stuff is well maintained anymore

[adrianinsaval]

this line should be adjusted or removed to make sure the file is being shipped. I don't understand why we ever wanted to remove license files anyways sounds top me like that is on the edge of being a license violation

FreeCAD-snap/snap/snapcraft.yaml

Line 323 in 9be8df1

find $CRAFT_PRIME/usr/share/doc/ -type f -not -name 'copyright' -delete

[luzpaz]

Fixed in 392dca0