first web app on founders site #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was out of scope
This fixes the problem that cordova overrides the window.open function which makes it stop working in the iOS mobile browser environment
move to more standard localStorage (can someone test in the native mobile apps?) and improve management of the tokens for the edge cases where the ajax request was not returning a proper token but error values
tiagoboldt
suggested changes
Apr 5, 2017
| app.getOAuthToken(); | ||
| } else { | ||
| app.token = storedToken; | ||
| app.showNotification("Found local slack auth token: "+app.token); |
There was a problem hiding this comment.
We shouldn't notify the user when things are working as expected. Furthermore, this notification is too large and hides the buttons when the application opens. I suggest removing it.
| }); | ||
| }); | ||
|
|
||
| app.initiateSlackAuth(); | ||
| app.showNotification("Device ready"); |
There was a problem hiding this comment.
I would also recommend removing this notification, for the same reasons as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making it workable on a browser platform