Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let Flow-Launcher/Flow.Launcher.Plugin.PythonTemplate readme could show #30

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Let Flow-Launcher/Flow.Launcher.Plugin.PythonTemplate readme could show #30

wants to merge 7 commits into from

Conversation

Zeroto521
Copy link
Member

image

@Zeroto521
Copy link
Member Author

The step could add https://github.com/Flow-Launcher/dotnet-template.

Zeroto521
Zeroto521 commented Aug 13, 2021
View reviewed changes
index.html Outdated Show resolved Hide resolved
@Zeroto521 Zeroto521 enabled auto-merge August 18, 2021 01:35
@Zeroto521
Copy link
Member Author

Ready to go

@Zeroto521 Zeroto521 disabled auto-merge August 18, 2021 02:34
@Zeroto521 Zeroto521 enabled auto-merge August 18, 2021 02:53
@Zeroto521 Zeroto521 disabled auto-merge August 19, 2021 12:56
@Zeroto521 Zeroto521 mentioned this pull request Aug 19, 2021
Closed
taooceros
taooceros reviewed Oct 28, 2021
View reviewed changes
Copy link
Member

@taooceros taooceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I just notice I didn't watch the repo, so couldn't receive notice about the pull request. Please check the comment, and then ready to go.

index.html Show resolved Hide resolved
index.html Outdated
Comment on lines 26 to 29
alias: {
'.*?/pytemplate':
'https://raw.githubusercontent.com/Flow-Launcher/Flow.Launcher.Plugin.PythonTemplate/master/README.md',
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, what does the alias do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that what I added pytemplate.md in _sidebar.md, doesn't exist in Flow-Launcher/docs project.
pytemplate.md is a reproject of Flow-Launcher/Flow.Launcher.Plugin.PythonTemplate/README.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, sorry for the huge late review.

@Zeroto521 Zeroto521 requested a review from taooceros August 16, 2022 03:17
@Zeroto521
rename pytemplate to python.template
9f2aea2 
Set standard name for later templates
such as `dotnet.template`
@Zeroto521
Copy link
Member Author

Change pytemplate to python.template.
Then we add easily add other templates such dotnet template which could be dotnet.template.

@taooceros
Copy link
Member

Is it possible to remove the icon for the sidebar?

@Zeroto521
Copy link
Member Author

Two methods could remove emojis. Simple one is remove them from the source. Another is change the logic of rendering sidebar. It's hard to finish in a short time.

jjw24
jjw24 requested changes Mar 28, 2024
View reviewed changes
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging I would like to drop Wox support in the template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjw24 jjw24 jjw24 requested changes

@taooceros taooceros taooceros approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@Zeroto521 Zeroto521

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeroto521 @taooceros @jjw24