Removed finalizers, optimized support for LispWorks, bug fix in examples. #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, there,
Thank you for your great works! I'm interested in using cl-sdl2-ttf in my own code adventures. After trying out code, I have eliminated some bugs and made some improvements, and I would like to share them with you and others.
This PR contains three major improvements/fixes.
struct sdl-color
as arguments in FFI call. As LispWorks' own FFI has already supported passing structs as arguments, we can omit this redundency by writing a bare-metal FFI call for LispWorks FFI.TTF_RenderGlyph_Shaded
. In these special kind of functions, the second argument to be passed should be anuint16
, wheras the master code mistakenly passed a C-string. I have fixed this bug for my LispWorks implementation.surface-pixels
in cl-sdl2 can have their own layout of pixels by adding paddings, sosurface-width
does not represent how much bytes are in a single scanline of the image. Changed it tosurface-pitch / 4
.Regards,
niwtr