-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support/1.17.x: fix fairdatapoint dependencies #604
Open
dennisvang
wants to merge
18
commits into
FAIRDataTeam:support/1.17.x
Choose a base branch
from
dennisvang:support/1.17.x
base: support/1.17.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support/1.17.x: fix fairdatapoint dependencies #604
dennisvang
wants to merge
18
commits into
FAIRDataTeam:support/1.17.x
from
dennisvang:support/1.17.x
+2,646
−2,665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and revert some erroneous modifications
…es to match v1.17.2
note that the package should actually be called org.fairdatateam.fairdatapoint or similar...
this still needs to be published to maven central, but in the meantime we can install the package locally using mvn install
fixes issue where lombok constructors were not being created: - 'constructor cannot be applied to given types' - 'no suitable constructor found' https://intellij-support.jetbrains.com/hc/en-us/community/posts/23064675521682-Lombok-not-workin-with-Intellij
also should use SpringBootaApplication(scanBasePackages = {...}) instead, if necessary
and add developer
dennisvang
force-pushed
the
support/1.17.x
branch
from
January 22, 2025 16:07
6f0ae19
to
aa09cda
Compare
for consistence with group id and other fairdatateam packages
dennisvang
force-pushed
the
support/1.17.x
branch
from
January 22, 2025 16:49
aa09cda
to
96696c6
Compare
dennisvang
force-pushed
the
support/1.17.x
branch
from
January 22, 2025 16:59
e530d35
to
a590965
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes for continued support of v1.17:
develop
branchnl.dtls
toorg.fairdatateam
fixes #501