Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Update the example #44

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] Update the example #44

wants to merge 2 commits into from

Conversation

rezkiy37
Copy link
Contributor

Details

The PR bumps the react-fast-pdf version of the example. Also, it fixes styles of the example.

Related Issues

Expensify/App#55176

Manual Tests

  1. Launch the example app.
  2. Open an example PDF file.
  3. Verify that there are no warnings in the console and that the file is displayed properly.

Linked PRs

#30 - introduced dynamically update container height that conflicts with example border styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rezkiy37