Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #508

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

badcaptain0001
Copy link

@badcaptain0001 badcaptain0001 commented Nov 15, 2024

I have added my portfolio rishabhsharma.vercel.app

Portfolio Author : Rihabh Sharma

Portfolio Link? : rishabhsharma.vercel.app

GitHub Link: https://github.com/badcaptain0001/rishabh_portfolio

Tech Stack : Nextjs, Tailwind CSS, TypeScript, Vercel, Swappy , Unsplash

I have added my portfolio rishabhsharma.vercel.app
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
portfolio-ideas ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 7:01am

Copy link

Hello @badcaptain0001, 🔥 thanks for raising a pull request in this project. Now, sit back and drink some coffee while we review this.

Copy link
Collaborator

@israelmitolu israelmitolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @badcaptain0001
Thanks for adding your portfolio. However, there are two things to adjust:

  1. Kindly add your portfolio to the bottom of the list.
  2. The screenshot is quite large (805kB). We have many images in the repo, so we try to make them as small as possible. Ideally less than 150kB.

Kindly compress it using compressnow or tinypng, and then reupload.

Thanks for your understanding :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants